Mir

Merge lp:~vanvugt/mir/remove-test-macros into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alexandros Frantzis
Approved revision: no longer in the source branch.
Merged at revision: 4095
Proposed branch: lp:~vanvugt/mir/remove-test-macros
Merge into: lp:mir
Diff against target: 44 lines (+0/-29)
2 files modified
tests/integration-tests/CMakeLists.txt (+0/-1)
tests/integration-tests/test_macros.cpp (+0/-28)
To merge this branch: bzr merge lp:~vanvugt/mir/remove-test-macros
Reviewer Review Type Date Requested Status
Alexandros Frantzis (community) Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+320301@code.launchpad.net

Commit message

Remove a deprecated test (testing things no longer used, but also causing
build problems on platforms that lack android-headers).

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4094
https://mir-jenkins.ubuntu.com/job/mir-ci/3191/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4290
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4377
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4367
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4367
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4367
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4317
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4317/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4317
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4317/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4317
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4317/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4317
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4317/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4317
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4317/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4317
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4317/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3191/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/integration-tests/CMakeLists.txt'
2--- tests/integration-tests/CMakeLists.txt 2017-02-15 14:45:41 +0000
3+++ tests/integration-tests/CMakeLists.txt 2017-03-20 05:23:46 +0000
4@@ -35,7 +35,6 @@
5 test_submit_buffer.cpp
6 test_display_info.cpp
7 test_display_server_main_loop_events.cpp
8- test_macros.cpp
9 test_surface_first_frame_sync.cpp
10 test_swapinterval.cpp
11 test_server_client_types.cpp
12
13=== removed file 'tests/integration-tests/test_macros.cpp'
14--- tests/integration-tests/test_macros.cpp 2015-02-22 07:46:25 +0000
15+++ tests/integration-tests/test_macros.cpp 1970-01-01 00:00:00 +0000
16@@ -1,28 +0,0 @@
17-/*
18- * Copyright © 2014 Canonical Ltd.
19- *
20- * This program is free software: you can redistribute it and/or modify
21- * it under the terms of the GNU General Public License version 3 as
22- * published by the Free Software Foundation.
23- *
24- * This program is distributed in the hope that it will be useful,
25- * but WITHOUT ANY WARRANTY; without even the implied warranty of
26- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
27- * GNU General Public License for more details.
28- *
29- * You should have received a copy of the GNU General Public License
30- * along with this program. If not, see <http://www.gnu.org/licenses/>.
31- *
32- * Authored by: Daniel van Vugt <daniel.van.vugt@canonical.com>
33- */
34-
35-#include "cutils/log.h" // Get the final value of LOG_NDEBUG
36-#include <gtest/gtest.h>
37-
38-TEST(Macros, android_verbose_logging_is_disabled)
39-{
40- // Ensure verbose logging (ALOGV) is removed. It requires significant
41- // CPU time to constantly format some verbose messages...
42- // This is a regression test for performance bug LP: #1343074.
43- EXPECT_EQ(1, LOG_NDEBUG);
44-}

Subscribers

People subscribed via source and target branches