Mir

Code review comment for lp:~vanvugt/mir/remove-hybrid-outputs-logging

Revision history for this message
Chris Halse Rogers (raof) wrote :

Weak disapprove.

I agree that we log similar information elsewhere in startup (and at other times), but I think this information is valuable enough to log. It shows some of the raw hardware state at startup, and associates it with the relevant device node; this is inherently driver-specific.

On a meta level, I think we log roughly an order of magnitude too little information on startup, so I place a low cost on extra once-off startup logging.

Since we don't plan to provide fake modes in our DisplayConfiguration I'd be happy enough for the supported modes information to be moved to the generic DisplayConfigurationReport.

review: Abstain

« Back to merge proposal