Mir

Merge lp:~vanvugt/mir/nextrelease into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3432
Proposed branch: lp:~vanvugt/mir/nextrelease
Merge into: lp:mir
Diff against target: 75 lines (+9/-8)
3 files modified
doc/dso_versioning_guide.md (+6/-5)
src/client/symbols.map (+1/-1)
src/protobuf/symbols.map (+2/-2)
To merge this branch: bzr merge lp:~vanvugt/mir/nextrelease
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Alberto Aguirre (community) Approve
Kevin DuBois (community) Approve
Andreas Pokorny (community) Approve
Alan Griffiths Approve
Review via email: mp+290273@code.launchpad.net

Commit message

Drop the 'unreleased' nomenclature in symbols.map. Aside from the fact
that we need to remember (and do forget) to change it at release, we
already know what that next release will be. So the intermediate step of
naming stanzas 'unreleased' is not necessary.

This makes the release process less error prone and a bit quicker.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3427
https://mir-jenkins.ubuntu.com/job/mir-ci/685/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/637
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/674
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/666
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/666
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/647
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/647/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/647
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/647/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/647
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/647/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/647
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/647/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/647
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/647/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/685/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> "we already know what that next release will be."

Do we though? I know it will usually be 0.(N+1).0 but is that always true?

review: Needs Information
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes, I assume the next series will almost always be 0.(N+1).

That assumption is factually true much more often than it's not (in fact it's never yet been untrue).

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Well, I hope it isn't always true: One day we might be releasing 1.0.0.

But on the occasions it isn't true we just need to rename in the release process (which is the same work we do now for every release).

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Exactly. For 99% of releases this branch will save us time and effort. The other 1% we'll require the same time and effort that 'unreleased' already does.

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

Agreed.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

lgtm too

review: Approve
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

OK though the "# New functions in Mir 0.x" comments are superfluous.

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/dso_versioning_guide.md'
2--- doc/dso_versioning_guide.md 2016-01-29 08:18:22 +0000
3+++ doc/dso_versioning_guide.md 2016-03-29 05:55:34 +0000
4@@ -6,8 +6,9 @@
5
6 There are more detailed descriptions below, but as a general rule:
7
8- - If you add a new symbol, add it to the `*_unreleased` version stanza,
9- like `MIR_CLIENT_unreleased`, `MIR_PLATFORM_unreleased`, etc.
10+ - If you add a new symbol, add it to a `*_NEXTSERIES` version stanza,
11+ like `MIR_CLIENT_0.22`, `MIR_PLATFORM_0.22`, etc representing the
12+ next future Mir series in which the new symbol will first be released.
13 - If you change the behaviour or signature of a symbol _and_ wish to preserve
14 backward compatibility, see "Change symbols without breaking ABI" below.
15 - At release time, rename the current `*_unversioned` stanzas to have the
16@@ -95,7 +96,7 @@
17 /* Other symbols go here */
18 };
19
20- MIR_CLIENT_unreleased {
21+ MIR_CLIENT_0.18 {
22 global:
23 mir_connect_new_symbol;
24 local:
25@@ -138,7 +139,7 @@
26 /* The old implementation */
27
28 /* The @@ specifies that this is the default version */
29- __asm__(".symver mir_connection_create_surface,mir_connection_create_surface@@@MIR_CLIENT_unreleased");
30+ __asm__(".symver mir_connection_create_surface,mir_connection_create_surface@@@MIR_CLIENT_0.18");
31 MirWaitHandle* mir_connection_create_surface(...)
32 /* The new implementation */
33
34@@ -151,7 +152,7 @@
35 ...
36 };
37
38- MIR_CLIENT_unreleased {
39+ MIR_CLIENT_0.18 {
40 global:
41 ...
42 mir_connection_create_surface;
43
44=== modified file 'src/client/symbols.map'
45--- src/client/symbols.map 2016-03-28 17:37:35 +0000
46+++ src/client/symbols.map 2016-03-29 05:55:34 +0000
47@@ -268,7 +268,7 @@
48 *;
49 } MIR_CLIENT_9v19;
50
51-MIR_CLIENT_unreleased {
52+MIR_CLIENT_0.22 { # New functions in Mir 0.22
53 global:
54 mir_connection_confirm_base_display_configuration;
55 mir_connection_preview_base_display_configuration;
56
57=== modified file 'src/protobuf/symbols.map'
58--- src/protobuf/symbols.map 2016-03-23 06:39:56 +0000
59+++ src/protobuf/symbols.map 2016-03-29 05:55:34 +0000
60@@ -1015,7 +1015,7 @@
61 };
62 } MIR_PROTOBUF_3;
63
64-MIR_PROTOBUF_unreleased {
65+MIR_PROTOBUF_0.22 { # New symbols in Mir 0.22
66 global:
67 extern "C++" {
68 mir::protobuf::PreviewConfiguration::ByteSize*;
69@@ -1037,4 +1037,4 @@
70 typeinfo?for?mir::protobuf::PreviewConfiguration;
71 vtable?for?mir::protobuf::PreviewConfiguration;
72 };
73-} MIR_PROTOBUF_3v19;
74\ No newline at end of file
75+} MIR_PROTOBUF_3v19;

Subscribers

People subscribed via source and target branches