Mir

Merge lp:~vanvugt/mir/log-power-mode into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3846
Proposed branch: lp:~vanvugt/mir/log-power-mode
Merge into: lp:mir
Diff against target: 15 lines (+5/-0)
1 file modified
src/server/report/logging/display_configuration_report.cpp (+5/-0)
To merge this branch: bzr merge lp:~vanvugt/mir/log-power-mode
Reviewer Review Type Date Requested Status
Chris Halse Rogers Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+311375@code.launchpad.net

Commit message

Log the current power mode of each output too.

I'm expecting this to be useful for debugging black screen issues
in future.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3834
https://mir-jenkins.ubuntu.com/job/mir-ci/2230/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2887
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2952
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2944
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2944
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2944
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2916
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2916/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2916
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2916/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2916
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2916/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2916
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2916/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2916
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2916/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2916
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2916/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2230/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote :

To match coding style (and be slightly clearer) it'd be char const* const power_mode[].

I'd vaguely prefer a lookup function, but I don't expect us to actually change the power mode enum at any point.

Seems sensible.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/server/report/logging/display_configuration_report.cpp'
2--- src/server/report/logging/display_configuration_report.cpp 2016-11-15 23:48:01 +0000
3+++ src/server/report/logging/display_configuration_report.cpp 2016-11-21 10:02:14 +0000
4@@ -94,6 +94,11 @@
5 logger->log(component, severity,
6 "%sPhysical size %.1f\" %dx%dmm",
7 indent, inches, width_mm, height_mm);
8+
9+ static const char* const power_mode[] =
10+ {"on", "in standby", "suspended", "off"};
11+ logger->log(component, severity,
12+ "%sPower is %s", indent, power_mode[out.power_mode]);
13
14 if (out.used)
15 {

Subscribers

People subscribed via source and target branches