Mir

Merge lp:~vanvugt/mir/fix-1662044 into lp:mir

Proposed by Daniel van Vugt on 2017-02-06
Status: Merged
Approved by: Daniel van Vugt on 2017-02-06
Approved revision: 4014
Merged at revision: 4014
Proposed branch: lp:~vanvugt/mir/fix-1662044
Merge into: lp:mir
Diff against target: 11 lines (+1/-1)
1 file modified
tests/acceptance-tests/test_client_input.cpp (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1662044
Reviewer Review Type Date Requested Status
Chris Halse Rogers 2017-02-06 Approve on 2017-02-06
Mir CI Bot continuous-integration Approve on 2017-02-06
Review via email: mp+316412@code.launchpad.net

Commit message

Drop a recently introduced 10 second wait to 1 second. (LP: #1662044)

Since it's only waiting to verify the absence of changes, a lower
timeout does not increase the risk of failure.

To post a comment you must log in.
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:4013
https://mir-jenkins.ubuntu.com/job/mir-ci/2942/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3897/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3976
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3966
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3966
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3966
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3924
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3924/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3924/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3924
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3924/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3924
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3924/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3924
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3924/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3924
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3924/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2942/rebuild

review: Needs Fixing (continuous-integration)
Daniel van Vugt (vanvugt) wrote :
lp:~vanvugt/mir/fix-1662044 updated on 2017-02-06
4014. By Daniel van Vugt on 2017-02-06

Try again

Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4014
https://mir-jenkins.ubuntu.com/job/mir-ci/2943/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3898
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3977
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3967
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3967
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3967
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3925
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3925/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3925
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3925/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3925
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3925/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3925
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3925/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3925
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3925/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3925
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3925/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2943/rebuild

review: Approve (continuous-integration)
Chris Halse Rogers (raof) wrote :

I'm happy for 1s as the standard for ‘wait for nothing to happen’; that's what I tend to use. 1s for “fail if something happens”, 10s for “fail if something doesn't happen”.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/acceptance-tests/test_client_input.cpp'
2--- tests/acceptance-tests/test_client_input.cpp 2017-02-01 14:56:28 +0000
3+++ tests/acceptance-tests/test_client_input.cpp 2017-02-06 05:47:31 +0000
4@@ -1151,7 +1151,7 @@
5 mir_connection_apply_session_input_config(unfocused_client.connection, config);
6 mir_input_config_release(config);
7
8- EXPECT_FALSE(expect_no_changes.wait_for(10s));
9+ EXPECT_FALSE(expect_no_changes.wait_for(1s));
10 mir_connection_set_input_config_change_callback(unfocused_client.connection, [](MirConnection*, void*){}, nullptr);
11 }
12

Subscribers

People subscribed via source and target branches