Mir

Merge lp:~vanvugt/mir/fix-1388686 into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2021
Proposed branch: lp:~vanvugt/mir/fix-1388686
Merge into: lp:mir
Diff against target: 21 lines (+2/-2)
2 files modified
src/client/mirclient.pc.in (+1/-1)
src/server/mirserver.pc.in (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1388686
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Review via email: mp+240390@code.launchpad.net

Commit message

Remind users of libmir{client,server} to go looking for symbols
in the new libmirprotobuf too (LP: #1388686)

Description of the change

Fixes FTBFS in both unity-system-compositor and qtmir.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Yep

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> The following tests FAILED:
> 34 - mir_acceptance_tests.TestClientInput.* (Failed)

Looks unrelated. Reapproving.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/client/mirclient.pc.in'
2--- src/client/mirclient.pc.in 2014-10-27 22:31:16 +0000
3+++ src/client/mirclient.pc.in 2014-11-03 04:34:55 +0000
4@@ -9,5 +9,5 @@
5 Description: Mir client library
6 Version: @MIR_VERSION@
7 Requires.private: protobuf >= 2.4.1
8-Libs: -L${libdir} -lmirclient
9+Libs: -L${libdir} -lmirclient -lmirprotobuf
10 Cflags: -I${includedir} -I${common_includedir}
11
12=== modified file 'src/server/mirserver.pc.in'
13--- src/server/mirserver.pc.in 2014-10-01 06:25:56 +0000
14+++ src/server/mirserver.pc.in 2014-11-03 04:34:55 +0000
15@@ -8,5 +8,5 @@
16 Version: @MIR_VERSION@
17 Requires.private: mirclient
18 Requires: mirplatform
19-Libs: -L@LIBDIR@ -lmirserver
20+Libs: -L@LIBDIR@ -lmirserver -lmirprotobuf
21 Cflags: -I@INCLUDEDIR@

Subscribers

People subscribed via source and target branches