Merge lp:~vanvugt/mir/fix-1369389 into lp:mir

[Daniel van Vugt]

Fix constructor syntax errors, which only just today g++ has decided
are fatal (LP: #1369389)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1916
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/2721/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1757
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1764
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1735/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1243
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/1243/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/672
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/672/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/2767/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13184

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/2721/rebuild

review: Needs Fixing (continuous-integration)

[Alexandros Frantzis (afrantzis)]

OK.

review: Approve

[Andreas Pokorny (andreas-pokorny)]

Tried with g++-4.9-13ubuntu1 and g++-4.9-10ubuntu2 this change does not cause a harm

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-autolanding/1074/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/1758
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/1765
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/1736/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-autolanding/458
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-autolanding/458/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/673
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/673/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/2768/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13188

review: Needs Fixing (continuous-integration)

=== modified file 'tests/include/mir_test/auto_unblock_thread.h'
--- tests/include/mir_test/auto_unblock_thread.h	2014-09-10 12:50:53 +0000
+++ tests/include/mir_test/auto_unblock_thread.h	2014-09-15 04:14:25 +0000
@@ -41,7 +41,7 @@
     explicit AutoUnblockThread(std::function<void(void)> const& unblock,
         Callable&& f,
         Args&&... args)
-        : unblock{unblock}, thread{f, args...}
+        : unblock{unblock}, thread(f, args...)
     {}
 
     ~AutoUnblockThread()
@@ -75,7 +75,7 @@
     template<typename Callable, typename... Args>
     explicit AutoJoinThread(Callable&& f,
         Args&&... args)
-        : AutoUnblockThread{[]{}, f, args...}
+        : AutoUnblockThread([]{}, f, args...)
     {}
 };