Code review comment for lp:~vanvugt/mir/fix-1350674
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Kevin:
* The overlay work still uses GLProgramFactory etc. I haven't touched that code here.
* New style namespaces: Yeah I think the new style is more readable. It avoids having multiple "{" at the start of lines without indentation (which is poor for readability).
* Default constructor: That's kind of intentional. If "= default" results in an actual empty constructor getting created inline then this approach is more efficient (less bytes and compiles faster). If "= default" results in the empty constructor not being created at all, then it would indeed be more efficient, but might still compile slower. So given this is something that you only construct once and constructor runtime performance is not the main issue, I think avoiding "= default" has more benefits here.
* string? Yeah I've intentionally used constant character pointers. We only need to support program source that is fixed in memory for the lifetime of the process. Although I wonder if "const char* const" would indicate that better...