lp:~vanvugt/mir/fix-1308905

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2014-04-23

Alan Griffiths: Approve on 2014-04-22

Diff: 39 lines (+8/-0)

1 file modified

tests/unit-tests/compositor/test_gl_renderer.cpp (+8/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1308905: [regression] GLRenderer* unit tests have recently become noisy

Low

Fix Released

Link a bug report

Related blueprints

1563. By Daniel van Vugt on 2014-04-17

Fix warnings arising from unexpected (uninteresting) mock_gl calls
(LP: #1308905)

1562. By Daniel van Vugt on 2014-04-17

First attempt at shrinking the docs. For me, this reduces the expanded
size from 119M to 65M. And 11M compressed (from 56M). (LP: #1304998). Fixes: https://bugs.launchpad.net/bugs/1304998.

Approved by Kevin DuBois, Robert Carr, Andreas Pokorny, PS Jenkins bot.

1561. By Kevin DuBois on 2014-04-17

When looking at the compositor code, I noticed two chunks of code that could be changed without making the tests fail.
Write an integration test that catches those interactions (among other common interactions between the SurfaceStack and compositor system) if they're changed. The tests check that the displaybuffer is posted at least a given number of times before a timeout. This is a multithreaded system, so the tests are designed to pass quickly (they fail on 5s timeout).

Approved by PS Jenkins bot, Andreas Pokorny, Alan Griffiths.

1560. By Alberto Aguirre on 2014-04-16

Remove stale socket files (LP: #1285215)

Stale socket files can be detected by checking the active socket connection table
at /proc/net/unix.
Stale socket files are files that exist, are of socket type
but don't have an active socket connection entry. Fixes: https://bugs.launchpad.net/bugs/1285215.

Approved by PS Jenkins bot, Alexandros Frantzis, Robert Carr, Alan Griffiths.

1559. By Kevin DuBois on 2014-04-16

graphics: move gl program creation code to a common place. Ensure gl program creation is serialized in the GLRenderer factory (as opposed to the constructor of the GLRenderer). Address some exception safety issues in making gl programs/shaders.

Approved by Alexandros Frantzis, Robert Carr, Alberto Aguirre, PS Jenkins bot.

1558. By Alberto Aguirre on 2014-04-16

Make MultiThreadedCompositor::start and MultiThreadedCompositor::stop exception safe.

Also to keep helgrind happy (LP: #1296544) allow it to establish a correct mutex locking order by avoiding holding the start guard lock while configuring the scene change callback in MultiThreadedCompositor::start.

Add a test to ensure start can safely be called again even if previous attempts resulted in an exception. Fixes: https://bugs.launchpad.net/bugs/1296544.

Approved by Alan Griffiths, PS Jenkins bot, Robert Carr, Alexandros Frantzis, Chris Halse Rogers.

1557. By Alberto Aguirre on 2014-04-15

Add a simple two digit on-screen counter egl based example.

Useful for debugging out of sequence frame issues.

Approved by Alan Griffiths, Andreas Pokorny, PS Jenkins bot.

1556. By Alexandros Frantzis on 2014-04-15

client: Split mir_client_library.(cpp|h) files into separate files.

Approved by Robert Carr, Andreas Pokorny, PS Jenkins bot, Alan Griffiths.

1555. By Alan Griffiths on 2014-04-15

scene: ApplicationSession can register its own surface observer.

Approved by PS Jenkins bot, Alberto Aguirre, Robert Carr, Andreas Pokorny, Alexandros Frantzis.

1554. By Daniel van Vugt on 2014-04-15

Bump server ABI to 19. Seems we've made enough header/class changes since
release 0.1.8 to require this.

Approved by PS Jenkins bot, Chris Halse Rogers.