Mir

Merge lp:~vanvugt/mir/fix-1287600 into lp:mir

  1. fix-1287600
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 1442
Proposed branch: lp:~vanvugt/mir/fix-1287600
Merge into: lp:mir
Diff against target: 9 lines (+1/-1)
1 file modified
cross-compile-chroot.sh (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1287600
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Chris Halse Rogers Approve
Review via email: mp+209190@code.launchpad.net

Commit message

Don't pass a parameter to bash's popd command. It doesn't expect one and will
return an error from cross-compile-chroot.sh. (LP: #1287600)

Description of the change

This appears to be one of the issues blocking 0.1.6 from entering distro
(https://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1099/console)

To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

Any idea why this has broken now? That line is unchanged since the introduction of the script.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

No idea. But *today* it's a rather glaring mistake :)

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Is there a good name for a bug that only manifests after it has been spotted?

Can we do something to "Schrodinger bug" along the liens of Heisenbug?

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Zombie cat bug?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1442
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/974/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1102
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/689
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/706
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/706/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/711
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/711/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/690
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/690/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/657
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4441

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/974/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cross-compile-chroot.sh'
2--- cross-compile-chroot.sh 2014-02-18 02:12:21 +0000
3+++ cross-compile-chroot.sh 2014-03-04 08:39:17 +0000
4@@ -80,4 +80,4 @@
5
6 make -j${NUM_JOBS}
7
8-popd ${BUILD_DIR} > /dev/null
9+popd > /dev/null

Subscribers

People subscribed via source and target branches