Mir

Merge lp:~vanvugt/mir/fix-1252144-v2 into lp:mir

  1. fix-1252144-v2
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 1234
Proposed branch: lp:~vanvugt/mir/fix-1252144-v2
Merge into: lp:mir
Diff against target: 11 lines (+1/-0)
1 file modified
tests/mir_test_doubles/test_protobuf_client.cpp (+1/-0)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1252144-v2
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
PS Jenkins bot (community) continuous-integration Approve
Alexandros Frantzis (community) Approve
Review via email: mp+195723@code.launchpad.net

Commit message

Fix uninitialized variable causing random drm_auth_magic test failures.
(LP: #1252144)

Description of the change

Why valgrind can't see that uninitialized value, I don't know. But the C++11 docs seem to say it should and will be uninitialized. And it's surrounded by variables that are explicitly initialized.

To post a comment you must log in.
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1233
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/395/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/214
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/211
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/124
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/124/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/124
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/124/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-team-mir-development-branch-ci/395/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Naturally

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/mir_test_doubles/test_protobuf_client.cpp'
2--- tests/mir_test_doubles/test_protobuf_client.cpp 2013-10-07 09:27:32 +0000
3+++ tests/mir_test_doubles/test_protobuf_client.cpp 2013-11-19 08:55:43 +0000
4@@ -46,6 +46,7 @@
5 next_buffer_called(false),
6 release_surface_called(false),
7 disconnect_done_called(false),
8+ drm_auth_magic_done_called(false),
9 configure_display_done_called(false),
10 tfd_done_called(false),
11 connect_done_count(0),

Subscribers

People subscribed via source and target branches