Merge lp:~vanvugt/mir/fix-1237332 into lp:mir

[Daniel van Vugt]

Fixed: Exceptions thrown from within compositing threads were untraceable,
resulting in a bunch of undebuggable crash reports (LP: #1237332).

Used the trivial workaround suggested in:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55917

Now crashes from compositor threads seem to provide useful stack traces.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1427
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/943/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1046
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1044
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/638
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/675
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/675/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/680
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/680/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/639
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/639/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/613
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4312

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/943/rebuild

review: Approve (continuous-integration)

[Alan Griffiths (alan-griffiths)]

This doesn't address the real problem (that exceptions are thrown and not handled) but mitigates the symptoms.

review: Approve

[Alexandros Frantzis (afrantzis)]

OK.

review: Approve

[Kevin DuBois (kdub)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-autolanding/415/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1053
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1051
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/645/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-autolanding/320
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-autolanding/320/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-autolanding/321/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/646/console

review: Needs Fixing (continuous-integration)

[Daniel van Vugt (vanvugt)]

All the valgrind+armhf failures appear to be unrelated to this branch. I can reproduce plenty with plain old development-branch on nexus4 :(

It doesn't seem to be bug 1284653 as we're using the newly fixed valgrind.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1428
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/951/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1058
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1056
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/650
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/683
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/683/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/688
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/688/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/651
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/651/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/622
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4335

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/951/rebuild

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

review: Approve

=== modified file 'src/server/compositor/multi_threaded_compositor.cpp'
--- src/server/compositor/multi_threaded_compositor.cpp	2014-01-22 08:32:55 +0000
+++ src/server/compositor/multi_threaded_compositor.cpp	2014-02-27 06:58:06 +0000
@@ -67,7 +67,7 @@
     {
     }
 
-    void operator()()
+    void operator()() noexcept  // noexcept is important! (LP: #1237332)
     {
         std::unique_lock<std::mutex> lock{run_mutex};