Mir

Merge lp:~vanvugt/mir/fix-1236697 into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: 1113
Merged at revision: 1115
Proposed branch: lp:~vanvugt/mir/fix-1236697
Merge into: lp:mir
Diff against target: 12 lines (+1/-1)
1 file modified
3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1236697
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Kevin DuBois (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+189763@code.launchpad.net

Commit message

Fix uninitialized variable (LP: #1236697)

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This also seems to resolve bug 1236698... (?)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Ignore that last comment. Eventually proven wrong.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) :
review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp'
2--- 3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp 2013-09-24 15:47:56 +0000
3+++ 3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp 2013-10-08 05:42:38 +0000
4@@ -2913,7 +2913,7 @@
5 }
6
7 // If moving between pointer modes, need to reset some state.
8- bool deviceModeChanged;
9+ bool deviceModeChanged = false;
10 if (mDeviceMode != oldDeviceMode) {
11 deviceModeChanged = true;
12 mOrientedRanges.clear();

Subscribers

People subscribed via source and target branches