Code review comment for lp:~vanvugt/mir/fatal-error
Revision history for this message
| Chris Halse Rogers (raof) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
That assumes that terminating is the correct behavior, and that everything they want to do is safe in a signal context, which it probably isn't.
-----Original Message-----
From: "Daniel van Vugt" <email address hidden>
Sent: 14/07/2014 18:32
To: "Daniel van Vugt" <email address hidden>
Subject: Re: [Merge] lp:~vanvugt/mir/fatal-error into lp:mir/devel
I thought users could utilize the emergency recovery code?... Or maybe it needs more API still?...
https:/
Inserting new handlers with that _should_ allow you to clean up on both exceptions and fatal signals.
If you relied on exceptions alone for clean up then you're missing out, because that will never catch crashes like SIGSEGV.
--
https:/
You are reviewing the proposed merge of lp:~vanvugt/mir/fatal-error into lp:mir/devel.