Mir

Code review comment for lp:~vanvugt/mir/fatal-error

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

"last time we had this discussion" I feel we made the wrong decision by allowing the offending change to land:
    https://code.launchpad.net/~afrantzis/mir/fix-1189770/+merge/217652

The reason being we have a collection of hidden critical bugs that will never be resolvable without this change. They're hiding in the duplicates list on the right-hand-side of:
    https://bugs.launchpad.net/mir/+bug/1237332

I believe the user experience of eventually not crashing at all is more important than recovering the screen but never fixing the crashes. Although we could achieve both if we utilize the existing logic that catches crashes and does lightweight recovery: server/run_mir.cpp
I think the screen/VT recovery should be there.

« Back to merge proposal