Mir

Merge lp:~vanvugt/mir/explicit-protobuf-version into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3711
Proposed branch: lp:~vanvugt/mir/explicit-protobuf-version
Merge into: lp:mir
Diff against target: 26 lines (+3/-0)
3 files modified
src/protobuf/mir_protobuf.proto (+1/-0)
src/protobuf/mir_protobuf_wire.proto (+1/-0)
tests/integration-tests/test_protobuf.proto (+1/-0)
To merge this branch: bzr merge lp:~vanvugt/mir/explicit-protobuf-version
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Cemil Azizoglu (community) Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+306059@code.launchpad.net

Commit message

Fix protobuf3 syntax warnings (LP: #1624971)

Description of the change

Although if vivid fails to build with this (protobuf2) then we will
need to just say "Won't Fix".

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3708
https://mir-jenkins.ubuntu.com/job/mir-ci/1751/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2195
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2258
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2249
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2249
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2249
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2223
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2223/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2223
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2223/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2223
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2223/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2223
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2223/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2223
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2223/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1751/rebuild

review: Approve (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

ok

review: Approve
Revision history for this message
Kevin DuBois (kdub) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/protobuf/mir_protobuf.proto'
2--- src/protobuf/mir_protobuf.proto 2016-09-16 15:18:36 +0000
3+++ src/protobuf/mir_protobuf.proto 2016-09-19 07:13:05 +0000
4@@ -1,3 +1,4 @@
5+syntax = "proto2";
6 option optimize_for = LITE_RUNTIME;
7
8 package mir.protobuf;
9
10=== modified file 'src/protobuf/mir_protobuf_wire.proto'
11--- src/protobuf/mir_protobuf_wire.proto 2016-01-29 08:18:22 +0000
12+++ src/protobuf/mir_protobuf_wire.proto 2016-09-19 07:13:05 +0000
13@@ -1,3 +1,4 @@
14+syntax = "proto2";
15 option optimize_for = LITE_RUNTIME;
16
17 package mir.protobuf.wire;
18
19=== modified file 'tests/integration-tests/test_protobuf.proto'
20--- tests/integration-tests/test_protobuf.proto 2016-03-30 01:12:38 +0000
21+++ tests/integration-tests/test_protobuf.proto 2016-09-19 07:13:05 +0000
22@@ -1,3 +1,4 @@
23+syntax = "proto2";
24 option optimize_for = LITE_RUNTIME;
25
26 package mir.protobuf.test;

Subscribers

People subscribed via source and target branches