Merge lp:~vanvugt/mir/dont-fudge-touch_event_latency-results into lp:mir

[Daniel van Vugt]

benchmarks/touch_event_latency.py: Remove incorrect usage of
MIR_CLIENT_INPUT_RATE=0.

Having it there would artificially lower benchmark results such that
they do not represent real-world performance where the rate is presently
set to 59 by default (thus input latency is actually some random value
between 0 and 16.9ms).

I'm in the process of retiring all input resampling code, so the entire
MIR_CLIENT_INPUT_RATE feature is going away soon. But I just noticed
this one particular instance that should never have been there in the
first place. So we can retire this bit right now.

Also the benchmark was broken before I touched it. It returns garbage mean values but stddev values sound like they are correct:

Before:
Nested server received 202 events
Kernel to nested server mean: 1483667840683.643555 ms stdev: 0.025868 ms
Client received 202 events
Kernel to client mean: 1483667840683.705078 ms stdev: 0.031450 ms

After:
Nested server received 122 events
Kernel to nested server mean: 1483667840689.388672 ms stdev: 2.103311 ms
Client received 121 events
Kernel to client mean: 1483667840689.515625 ms stdev: 2.042743 ms

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:3907
https://mir-jenkins.ubuntu.com/job/mir-ci/2547/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3312
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3379
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3371
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3371
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/3371
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/3341
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3341
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/3341
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3341
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3341
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3341
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3341/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2547/rebuild

review: Approve (continuous-integration)

[Kevin DuBois (kdub)]

sure

review: Approve

=== modified file 'benchmarks/touch_event_latency.py'
--- benchmarks/touch_event_latency.py	2015-07-02 14:40:40 +0000
+++ benchmarks/touch_event_latency.py	2017-01-06 08:45:44 +0000
@@ -57,13 +57,9 @@
 
 ####### TEST #######
 
-# Disable input resampling so that the event_time field of input events,
-# used to calculate latency, is accurate
-no_resampling_env = {"MIR_CLIENT_INPUT_RATE": "0"}
-
 host = Server(reports=["input"])
-nested = Server(host=host, reports=["client-input-receiver"], env=no_resampling_env)
-client = Client(server=nested, reports=["client-input-receiver"], options=["-f"], env=no_resampling_env)
+nested = Server(host=host, reports=["client-input-receiver"])
+client = Client(server=nested, reports=["client-input-receiver"], options=["-f"])
 
 test = PerformanceTest([host, nested, client])
 touch_screen = TouchScreen()