Mir

Merge lp:~vanvugt/mir/display-report-valid into lp:mir

  1. display-report-valid
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 3509
Proposed branch: lp:~vanvugt/mir/display-report-valid
Merge into: lp:mir
Diff against target: 15 lines (+3/-3)
1 file modified
src/server/report/logging/display_report.cpp (+3/-3)
To merge this branch: bzr merge lp:~vanvugt/mir/display-report-valid
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Cemil Azizoglu (community) Approve
Review via email: mp+294601@code.launchpad.net

Commit message

When using --display-report=log, only print valid EGL attributes.
Avoid printing uninitialized values for those that are absent.
(LP: #1582066)

To post a comment you must log in.
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

makes sense

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/server/report/logging/display_report.cpp'
2--- src/server/report/logging/display_report.cpp 2015-04-28 07:54:10 +0000
3+++ src/server/report/logging/display_report.cpp 2016-05-13 06:23:43 +0000
4@@ -141,9 +141,9 @@
5 for( auto &i : egl_string_mapping)
6 {
7 EGLint value;
8- eglGetConfigAttrib(disp, config, i.val, &value);
9- logger->log(ml::Severity::informational,
10- " [" + i.name + "] : " + std::to_string(value), component());
11+ if (eglGetConfigAttrib(disp, config, i.val, &value))
12+ logger->log(ml::Severity::informational,
13+ " [" + i.name + "] : " + std::to_string(value), component());
14 }
15 }
16

Subscribers

People subscribed via source and target branches