Mir

Merge lp:~vanvugt/mir/deprecate-mir_buffer_stream_swap_buffers into lp:mir

Proposed by Daniel van Vugt on 2017-05-02
Status: Merged
Approved by: Alan Griffiths on 2017-05-12
Approved revision: 4160
Merged at revision: 4166
Proposed branch: lp:~vanvugt/mir/deprecate-mir_buffer_stream_swap_buffers
Merge into: lp:mir
Diff against target: 13 lines (+2/-1)
1 file modified
include/client/mir_toolkit/mir_buffer_stream.h (+2/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/deprecate-mir_buffer_stream_swap_buffers
Reviewer Review Type Date Requested Status
Alan Griffiths 2017-05-02 Approve on 2017-05-12
Mir CI Bot continuous-integration Approve on 2017-05-02
Review via email: mp+323484@code.launchpad.net

Commit message

Deprecate mir_buffer_stream_swap_buffers()

For several reasons:
 * It returns a MirWaitHandle, which is already deprecated.
 * It is only used by one downstream project (Xmir), possibly zero if
   that is now a deprecated project.
 * It is high latency (not yet ported to use client-side vsync).
 * It is not thread-safe (LP: #1194384).
 * An alternative without these drawbacks will soon be available:
   https://code.launchpad.net/~vanvugt/mir/manual-vsync-api-v3/+merge/323452

Description of the change

Has a weak dependency/prerequisite on:
https://code.launchpad.net/~vanvugt/mir/manual-vsync-api-v3/+merge/323452

or whatever branch that lands solving that problem.

To post a comment you must log in.
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4160
https://mir-jenkins.ubuntu.com/job/mir-ci/3388/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4587
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4715
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4704
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4704
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4619
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4619/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4619
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4619/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4619
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4619/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4619
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4619/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4619
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4619/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3388/rebuild

review: Approve (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/client/mir_toolkit/mir_buffer_stream.h'
2--- include/client/mir_toolkit/mir_buffer_stream.h 2017-04-13 07:00:27 +0000
3+++ include/client/mir_toolkit/mir_buffer_stream.h 2017-05-02 08:25:45 +0000
4@@ -184,7 +184,8 @@
5 MirWaitHandle *mir_buffer_stream_swap_buffers(
6 MirBufferStream *buffer_stream,
7 MirBufferStreamCallback callback,
8- void *context);
9+ void *context)
10+__attribute__ ((deprecated("For non-blocking swaps use mir_buffer_stream_swap_buffers_sync with an interval of zero. And a client API for manual vsync will soon be available.")));
11
12 /**
13 * Advance a buffer stream's buffer as in mir_buffer stream_swap_buffers(),

Subscribers

People subscribed via source and target branches