Code review comment for lp:~vanvugt/mir/ddouble
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
I agree that the new unit tests cover the new behavior of BufferQueue.
But I disagree that the proposed tests cover the new functionality of the system: there are no new tests of /the system as a whole/. The potential value of such tests is clear from the "Description of the Change" detailing how to /manually/ test the new functionality.
We should always be looking for ways to avoid relying on manual testing and this seems like an opportunity.