Merge lp:~vanvugt/mir/android-prefer-truecolor into lp:mir
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp:~vanvugt/mir/android-prefer-truecolor |
| Merge into: | lp:mir |
| Diff against target: |
26 lines (+6/-0) 2 files modified
src/platforms/android/server/gl_context.cpp (+3/-0) src/platforms/android/server/hwc_blanking_control.cpp (+3/-0) |
| To merge this branch: | bzr merge lp:~vanvugt/mir/android-prefer-truecolor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel van Vugt | Abstain | ||
| Mir CI Bot | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Android: Prefer the highest colour depth (>= 15 bit) available instead
of defaulting the lowest depth.
If the Android driver follows the EGL spec it will now choose the highest
colour depth. Previously we defaulted to zeros which meant we were asking
for the lowest colour depth. It was only by chance that we supported
devices with buggy EGL implementations before now that didn't follow the
spec and they gave us true colour erroneously.
https:/
https:/
Description of the change
UNTESTED proof of concept for morphis. Theoretically this can't make the problem any worse at least.
I know it's counter-intuitive but asking for 5 bits is the best way to get 8 bits. Because EGL says that any value greater than zero will give you the maximum colour depth available. And asking for 5 means your code will still work if only high colour is available.
| Mir CI Bot (mir-ci-bot) wrote | # |
| Daniel van Vugt (vanvugt) | # |
| Simon Fels (morphis) wrote | # |
Unmerged revisions
- 3526. By Daniel van Vugt
-
Proof of concept
FAILED: Continuous integration, rev:3526
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/