Merge lp:~vanvugt/gsettings-ubuntu-touch-schemas/fix-1607240 into lp:gsettings-ubuntu-touch-schemas

Proposed by Daniel van Vugt on 2016-08-01
Status: Merged
Approved by: Iain Lane on 2016-08-10
Approved revision: 71
Merged at revision: 73
Proposed branch: lp:~vanvugt/gsettings-ubuntu-touch-schemas/fix-1607240
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 25 lines (+2/-4)
1 file modified
accountsservice/com.ubuntu.AccountsService.Input.xml (+2/-4)
To merge this branch: bzr merge lp:~vanvugt/gsettings-ubuntu-touch-schemas/fix-1607240
Reviewer Review Type Date Requested Status
Iain Lane 2016-08-01 Approve on 2016-08-10
Lukáš Tinkl (community) 2016-08-02 Approve on 2016-08-04
Review via email: mp+301605@code.launchpad.net

Commit message

Correct the default scroll speed multiplier which should be 1.0 after
the other fixes for LP: #1607240 are in place in qtmir and qtubuntu.

Also remove comments suggesting that 1.0 is the maximum. Actually 1.0
is just the default/native speed and it's likely some users will want
higher values than 1.0 in future. A corresponding QML fix in
ubuntu-system-settings to raise this limit will be required.
(LP: #1607240)

To post a comment you must log in.
Lukáš Tinkl (lukas-kde) wrote :

LGTM, makes sense together with the other patches

review: Approve
Iain Lane (laney) wrote :

Okey

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/com.ubuntu.AccountsService.Input.xml'
2--- accountsservice/com.ubuntu.AccountsService.Input.xml 2016-04-05 17:22:15 +0000
3+++ accountsservice/com.ubuntu.AccountsService.Input.xml 2016-08-01 02:50:46 +0000
4@@ -16,9 +16,8 @@
5 <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.75"/>
6 </property>
7
8- <!-- 0 to 1 -->
9 <property name="MouseScrollSpeed" type="d" access="readwrite">
10- <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.5"/>
11+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="1.0"/>
12 </property>
13
14 <!-- in milliseconds -->
15@@ -36,9 +35,8 @@
16 <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.75"/>
17 </property>
18
19- <!-- 0 to 1 -->
20 <property name="TouchpadScrollSpeed" type="d" access="readwrite">
21- <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.5"/>
22+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="1.0"/>
23 </property>
24
25 <!-- in milliseconds -->

Subscribers

People subscribed via source and target branches