Merge lp:~vanvugt/gdm/fix-1704050 into lp:~ubuntu-desktop/gdm/ubuntu
Proposed by
Daniel van Vugt
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 425 |
Merged at revision: | 425 |
Proposed branch: | lp:~vanvugt/gdm/fix-1704050 |
Merge into: | lp:~ubuntu-desktop/gdm/ubuntu |
Diff against target: |
59 lines (+39/-0) 3 files modified
debian/changelog (+7/-0) debian/patches/Avoid-double-NULL-terminated-array-LP-1704050.patch (+31/-0) debian/patches/series (+1/-0) |
To merge this branch: | bzr merge lp:~vanvugt/gdm/fix-1704050 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Approve | ||
Jeremy Bícha | Pending | ||
Ubuntu Desktop | Pending | ||
Review via email: mp+327360@code.launchpad.net |
Commit message
Avoid double-NULL terminated array (LP: #1704050)
If you then g_array_append_val wayland_search_dir you get:
{..., NULL, wayland_search_dir, NULL}
and so the call to g_strdupv never finds wayland_search_dir. And then
Wayland logins don't work.
Neither G_N_ELEMENTS nor g_array_append_vals treat NULL as a special value. Only g_strdupv does.
Description of the change
Patch generated against upstream git so hopefully they will accept the same .patch file.
To post a comment you must log in.
+1, as discussed on IRC, thanks!