Merge lp:~vanvugt/compiz/fix-731685-trunk into lp:~compiz/compiz/ubuntu
Status: | Superseded |
---|---|
Proposed branch: | lp:~vanvugt/compiz/fix-731685-trunk |
Merge into: | lp:~compiz/compiz/ubuntu |
Diff against target: |
127 lines (+117/-0) 2 files modified
debian/patches/fix_dock_shadow_artifacts.patch (+116/-0) debian/patches/series (+1/-0) |
To merge this branch: | bzr merge lp:~vanvugt/compiz/fix-731685-trunk |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sam Spilsbury | Pending | ||
compiz packagers | Pending | ||
Review via email: mp+70836@code.launchpad.net |
This proposal has been superseded by a proposal from 2011-09-01.
Description of the change
Fix dock shadow artifacts with rounded window decorations. (LP: #731685)
Removes the assumption that all window decorations are rectangular when overlapping the shadow of a dock like gnome-panel. This false assumption was added to compiz 0.9.4 apparently for performance reasons, however it causes visible artifacts where the shadow should be visible.
The patch contained in this proposal was developed and tested on natty, however it appears to be compatible with oneiric also (thankfully).
Fixing bug 731685 is particularly useful because it opens the door for us to be able to eliminate and simplify the redundant shadowing code in unity (panel). This should allow us to fix other outstanding unity shadow bugs quite easily.
Unmerged revisions
- 639. By Daniel van Vugt
-
Fix dock shadow artifacts with rounded window decorations. (LP: #731685)
- 638. By Sam Spilsbury
-
Remove symbols that we're not shipping anymore
- 637. By Didier Roche-Tolomelli
-
* New upstream release
* debian/compiz- gnome.install:
- install gsettings schemas
Indeed this assumption (window is not transformed) is in place.
However, I'd prefer not to render shadows on top of the desktop window. I think that there's a better way to handle this and ensure that we're not rendering the decoration twice. It might be worth clipping the shadow based on the frame region rather than the border rect itself.