lp:~vanvugt/compiz/fix-1097664

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3552

PS Jenkins bot (community): Approve (continuous-integration) on 2013-01-09

Sam Spilsbury: Approve on 2013-01-09

Diff: 40 lines (+7/-1)

3 files modified

plugins/opengl/include/opengl/opengl.h (+1/-1)
plugins/opengl/include/opengl/shadercache.h (+1/-0)
plugins/opengl/src/shadercache.cpp (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1097664: GLShaderCache::priv [PrivateShaderCache] is leaked

Medium

Fix Released

Link a bug report

Related blueprints

3550. By Daniel van Vugt on 2013-01-09

Avoid leaking GLShaderCache::priv (LP: #1097664)

I have bumped the opengl ABI for completeness but it's probably not necessary
because:
  (a) No code outside of the opengl plugin uses GLShaderCache; and
  (b) Even if there was code using it, I'm not sure if the addition of a
      non-virtual destructor would affect the binary object size.

3549. By Daniel van Vugt on 2013-01-08

Fix memory leaks resulting from misuse (and poor design) of
resize::CompScreenImpl::findWindow()
(LP: #1097126)
. Fixes: https://bugs.launchpad.net/bugs/1097126.

Approved by Daniel d'Andrada, PS Jenkins bot.

3548. By Daniel van Vugt on 2013-01-08

Reintroduced the wallpaper plugin. It was unbuildable from v0.9.8.0 until
now. (LP: #1020830). Fixes: https://bugs.launchpad.net/bugs/1020830.

Approved by Daniel van Vugt, Sam Spilsbury.

3547. By MC Return on 2013-01-08

Minor showmouse clean-up:

Fixed indentation in and simplified showmouse.xml.in (no need for 2 General groups/tabs).
Fixed several typos.

Approved by Daniel van Vugt.

3546. By Daniel van Vugt on 2013-01-08

Sort the plugin list to improve readability of CMake output (LP: #1096780). Fixes: https://bugs.launchpad.net/bugs/1096780.

Approved by PS Jenkins bot, Sam Spilsbury.

3545. By Daniel van Vugt on 2013-01-07

Be sure to treat \r and \n as word boundaries too. Otherwise CMake will read
expo's plugin name as "expo\n" from plugins/expo/CMakeLists.txt resulting
in weird and misleading "Disabled" messages for expo.
(LP: #1083027). Fixes: https://bugs.launchpad.net/bugs/1083027.

Approved by PS Jenkins bot, Sam Spilsbury.

3544. By MC Return on 2013-01-07

Fixed dimention->dimension typos.

Approved by Daniel van Vugt.

3543. By Michail Bitzes on 2013-01-07

Added missing glEnable/glDisableClientState calls for GL_TEXTURE_COORD_ARRAY and GL_VERTEX_ARRAY to make showmouse work with the new codebase.

Credits and thanks for this patch go to Michail Bitzes.

(LP: #1048267). Fixes: https://bugs.launchpad.net/bugs/1048267.

Approved by Daniel van Vugt.

3542. By Sam Spilsbury on 2013-01-07

Fixed: Clicking on semi-maximized windows in a different workspace fails to
switch to the correct workspace. (LP: #1037164). Fixes: https://bugs.launchpad.net/bugs/1037164.

Approved by Daniel van Vugt, PS Jenkins bot.

3541. By Sam Spilsbury on 2013-01-07

Port cubeaddon plugin to use new OpenGL plugin API.
(LP: #1020823)

Since the arrangement of the vertex data assumes quad usage, and GL_QUADS primitives are not available in OpenGL|ES, the option "deform caps" will be nonfunctional in OpenGL|ES builds. Fixes: https://bugs.launchpad.net/bugs/1020823.

Approved by Daniel van Vugt, PS Jenkins bot, Sam Spilsbury.