Merge lp:~vanvugt/compiz/fix-1097179 into lp:compiz/0.9.9

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3550
Merged at revision: 3550
Proposed branch: lp:~vanvugt/compiz/fix-1097179
Merge into: lp:compiz/0.9.9
Diff against target: 32 lines (+5/-3)
1 file modified
plugins/resize/src/logic/tests/test-logic.cpp (+5/-3)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1097179
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
PS Jenkins bot continuous-integration Pending
Daniel d'Andrada Pending
Review via email: mp+142443@code.launchpad.net

Commit message

Fix multiple errors reported by valgrind in compiz_test_resize_logic
"Conditional jump or move depends on uninitialised value(s)"
(LP: #1097179)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/resize/src/logic/tests/test-logic.cpp'
2--- plugins/resize/src/logic/tests/test-logic.cpp 2012-09-03 21:21:12 +0000
3+++ plugins/resize/src/logic/tests/test-logic.cpp 2013-01-09 05:34:23 +0000
4@@ -90,6 +90,10 @@
5 EXPECT_CALL (mockWindow, state ())
6 .WillRepeatedly (ReturnPointee (&mockWindowState));
7
8+ mockWindowBorder.left = 1;
9+ mockWindowBorder.right = 2;
10+ mockWindowBorder.top = 3;
11+ mockWindowBorder.bottom = 4;
12 EXPECT_CALL (mockWindow, border ())
13 .WillRepeatedly (ReturnRef (mockWindowBorder));
14
15@@ -144,8 +148,6 @@
16 EXPECT_CALL (mockScreen, compositingActive ())
17 .WillRepeatedly (Return (true));
18
19- EXPECT_CALL (mockScreen, damageRegion (_));
20-
21 EXPECT_CALL (mockScreen, syncEvent ())
22 .WillRepeatedly (Return (-XSyncAlarmNotify));
23
24@@ -178,7 +180,7 @@
25 {
26 logic.resizeInformationAtom = &fakePropWriter;
27 logic.mScreen = &mockScreen;
28- logic.cScreen = &mockScreen;
29+ logic.cScreen = NULL; // avoid entering CompositeScreen during tests
30 logic.gScreen = &mockScreen;
31 logic.options = &resizeOptions;
32 }

Subscribers

People subscribed via source and target branches