Merge lp:~vanvugt/compiz/fix-1089250 into lp:compiz/0.9.9

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3524
Merged at revision: 3526
Proposed branch: lp:~vanvugt/compiz/fix-1089250
Merge into: lp:compiz/0.9.9
Diff against target: 31 lines (+0/-21)
1 file modified
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_setting.cpp (+0/-21)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1089250
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+139397@code.launchpad.net

Commit message

Remove unused functions, which is an error for clang (LP: #1089250)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Yep, must have been an oversight while refactoring. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/libcompizconfig/tests/compizconfig_test_ccs_setting.cpp'
2--- compizconfig/libcompizconfig/tests/compizconfig_test_ccs_setting.cpp 2012-12-07 06:01:09 +0000
3+++ compizconfig/libcompizconfig/tests/compizconfig_test_ccs_setting.cpp 2012-12-12 08:12:21 +0000
4@@ -550,27 +550,6 @@
5 return settingValue;
6 }
7
8-CCSSettingValuePtr
9-ListValueToSettingValueList (CCSSettingValue *listChild)
10-{
11- listChild->isListChild = TRUE;
12-
13- CCSSettingValueList valueListHead = ccsSettingValueListAppend (NULL, listChild);
14- CCSSettingValuePtr valueListValue (AutoDestroy (NewCCSSettingValue (),
15- ccsSettingValueUnref));
16-
17- valueListValue->value.asList = valueListHead;
18-
19- return valueListValue;
20-}
21-
22-template <typename SettingValueType>
23-CCSSettingValuePtr
24-RawValueToListValue (const SettingValueType &value)
25-{
26- return ListValueToSettingValueList (RawValueToCCSValue (value));
27-}
28-
29 class ContainedValueGenerator
30 {
31 private:

Subscribers

People subscribed via source and target branches