Compiz

Merge lp:~vanvugt/compiz/fix-1087193 into lp:compiz/0.9.9

  1. fix-1087193
  2. Merge into 0.9.9
Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3511
Merged at revision: 3513
Proposed branch: lp:~vanvugt/compiz/fix-1087193
Merge into: lp:compiz/0.9.9
Diff against target: 12 lines (+1/-1)
1 file modified
src/window.cpp (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1087193
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+138410@code.launchpad.net

Commit message

Fixed windows not responding to input if XShape is disabled/absent.
It was a simple copy/paste error; passing nInput=0 instead of nInput=1 to:
    priv->inputRegion += rectsToRegion (nInput, inputShapeRects);
(LP: #1087193)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Thanks.

We also need to get this code under test.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3511
http://jenkins.qa.ubuntu.com/job/compiz-ci/303/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/303/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/303//rebuild/?

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2012-12-05 09:38:59 +0000
3+++ src/window.cpp 2012-12-06 10:19:23 +0000
4@@ -932,7 +932,7 @@
5 if (nInput < 1)
6 {
7 inputShapeRects = &r;
8- nBounding = 1;
9+ nInput = 1;
10 }
11
12 priv->region += rectsToRegion (nBounding, boundingShapeRects);

Subscribers

People subscribed via source and target branches