Merge lp:~vanvugt/compiz/fix-1086779 into lp:compiz/0.9.9
Proposed by
Daniel van Vugt
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | 3501 |
Merged at revision: | 3508 |
Proposed branch: | lp:~vanvugt/compiz/fix-1086779 |
Merge into: | lp:compiz/0.9.9 |
Diff against target: |
22 lines (+0/-5) 1 file modified
plugins/opengl/src/screen.cpp (+0/-5) |
To merge this branch: | bzr merge lp:~vanvugt/compiz/fix-1086779 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sam Spilsbury | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+138138@code.launchpad.net |
Commit message
Remove calls to eglWaitGL which are likely to hinder performance on GLES/ARM
platforms. The calls seem to be pointless and have a significant potential
impact on performance. Also remove XFlush in the same location, apparently
pointless.
(LP: #1086779)
Description of the change
In case you're wondering, the calls to eglSwapBuffers and eglPostSubBufferNV ahead of the deleted code both do an implicit glFlush already.
The difference is that eglWaitGL is equivalent to a glFinish, which is completely synchronous and usually has a massive impact on performance. It will prevent the CPU and GPU from being able to operate in parallel.
To post a comment you must log in.
PASSED: Continuous integration, rev:3501 jenkins. qa.ubuntu. com/job/ compiz- ci/298/ jenkins. qa.ubuntu. com/job/ compiz- ci/./build= pbuilder, distribution= quantal, flavor= amd64/298/ console
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: jenkins. qa.ubuntu. com/job/ compiz- ci/298/ /rebuild/?
http://