Merge lp:~vanvugt/compiz/fix-1083027 into lp:compiz/0.9.9

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3541
Merged at revision: 3545
Proposed branch: lp:~vanvugt/compiz/fix-1083027
Merge into: lp:compiz/0.9.9
Diff against target: 16 lines (+2/-2)
1 file modified
cmake/CompizPackage.cmake (+2/-2)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1083027
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+142064@code.launchpad.net

Commit message

Be sure to treat \r and \n as word boundaries too. Otherwise CMake will read
expo's plugin name as "expo\n" from plugins/expo/CMakeLists.txt resulting
in weird and misleading "Disabled" messages for expo.
(LP: #1083027)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Yay regex.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/CompizPackage.cmake'
2--- cmake/CompizPackage.cmake 2012-09-12 10:19:47 +0000
3+++ cmake/CompizPackage.cmake 2013-01-07 08:10:26 +0000
4@@ -54,10 +54,10 @@
5 )
6 foreach (_plugin ${_plugins_in})
7 file (READ "${_folder}/${_plugin}" _file)
8- if (_file MATCHES "^.*compiz_plugin ?\\(([^\\) ]*).*$")
9+ if (_file MATCHES "^.*compiz_plugin ?\\(([^\\)\r\n ]*).*$")
10 string (
11 REGEX REPLACE
12- "^.*compiz_plugin ?\\(([^\\) ]*).*$" "\\1"
13+ "^.*compiz_plugin ?\\(([^\\)\r\n ]*).*$" "\\1"
14 _plugin_name ${_file}
15 )
16 else ()

Subscribers

People subscribed via source and target branches