Merge lp:~vanvugt/compiz/fix-1068518 into lp:compiz/0.9.9

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3439
Merged at revision: 3444
Proposed branch: lp:~vanvugt/compiz/fix-1068518
Merge into: lp:compiz/0.9.9
Diff against target: 24 lines (+6/-2)
1 file modified
plugins/resize/src/resize.cpp (+6/-2)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1068518
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
MC Return Approve
Sam Spilsbury Pending
Review via email: mp+131552@code.launchpad.net

This proposal supersedes a proposal from 2012-10-19.

Commit message

Stop the resize border (Rectangle resize mode) from flickering slightly.
This was due to the damage/redraw rectangle being too small to include it,
so the border was overdrawing itself without the pixels behind it being
redrawn first.
(LP: #1068518)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

The Jenkins failure is bug 1071238. A fix is coming.

Revision history for this message
Sam Spilsbury (smspillaz) wrote : Posted in a previous version of this proposal

The build will soon be green, resubmit to get a green CI review.

review: Needs Resubmitting
Revision history for this message
MC Return (mc-return) wrote :

LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

... try again and / or merge trunk

lp:~vanvugt/compiz/fix-1068518 updated
3439. By Daniel van Vugt

Merge latest lp:compiz

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/resize/src/resize.cpp'
2--- plugins/resize/src/resize.cpp 2012-08-22 06:08:44 +0000
3+++ plugins/resize/src/resize.cpp 2012-10-29 10:24:21 +0000
4@@ -178,7 +178,8 @@
5 }
6
7 /* draw outline */
8- glLineWidth (2.0);
9+ static const int borderWidth = 2;
10+ glLineWidth (borderWidth);
11 streamingBuffer->begin (GL_LINES);
12 streamingBuffer->addColors (1, borderColor);
13 streamingBuffer->addVertices (8, &vertexData2[0]);
14@@ -194,7 +195,10 @@
15 #endif
16
17 CompositeScreen *cScreen = CompositeScreen::get (screen);
18- CompRect damage (box.x1, box.y1, box.x2 - box.x1, box.y2 - box.y1);
19+ CompRect damage (box.x1 - borderWidth,
20+ box.y1 - borderWidth,
21+ box.x2 - box.x1 + 2 * borderWidth,
22+ box.y2 - box.y1 + 2 * borderWidth);
23 cScreen->damageRegion (damage);
24 }
25

Subscribers

People subscribed via source and target branches