Merge lp:~vanvugt/compiz/fix-1067234 into lp:compiz/0.9.9

Proposed by Sam Spilsbury
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3421
Merged at revision: 3426
Proposed branch: lp:~vanvugt/compiz/fix-1067234
Merge into: lp:compiz/0.9.9
Diff against target: 146 lines (+1/-119)
2 files modified
src/point/CMakeLists.txt (+1/-9)
src/point/include/core/point.h (+0/-110)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1067234
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+129885@code.launchpad.net

This proposal supersedes a proposal from 2012-10-16.

Commit message

Remove duplicate point.h (LP: #1067234)

I had to keep the copy in include/ rather than the one in src/ because it's
used by include/core/{window,screen}.h. Doing it the other way around caused
pain and complication.

Description of the change

Remove duplicate point.h (LP: #1067234)

I had to keep the copy in include/ rather than the one in src/ because it's
used by include/core/{window,screen}.h. Doing it the other way around caused
pain and complication.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Dunno what's up with those test failures - they are completely unrelated. Lets see if it fails again.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/point/CMakeLists.txt'
2--- src/point/CMakeLists.txt 2012-01-23 17:46:28 +0000
3+++ src/point/CMakeLists.txt 2012-10-16 13:21:38 +0000
4@@ -5,16 +5,8 @@
5 )
6
7 INCLUDE_DIRECTORIES (
8- ${CMAKE_CURRENT_SOURCE_DIR}/include
9- ${CMAKE_CURRENT_SOURCE_DIR}/src
10-
11- ${CMAKE_CURRENT_SOURCE_DIR}/point/include
12- ${CMAKE_CURRENT_SOURCE_DIR}/point/src
13-
14 ${compiz_SOURCE_DIR}/include
15-
16 ${Boost_INCLUDE_DIRS}
17-
18 ${GLIBMM_INCLUDE_DIRS}
19 )
20
21@@ -22,7 +14,7 @@
22
23 SET (
24 PUBLIC_HEADERS
25- ${CMAKE_CURRENT_SOURCE_DIR}/include/core/point.h
26+ ${compiz_SOURCE_DIR}/include/core/point.h
27 )
28
29 SET (
30
31=== removed directory 'src/point/include'
32=== removed directory 'src/point/include/core'
33=== removed file 'src/point/include/core/point.h'
34--- src/point/include/core/point.h 2012-01-19 19:16:27 +0000
35+++ src/point/include/core/point.h 1970-01-01 00:00:00 +0000
36@@ -1,110 +0,0 @@
37-/*
38- * Copyright © 2008 Dennis Kasprzyk
39- *
40- * Permission to use, copy, modify, distribute, and sell this software
41- * and its documentation for any purpose is hereby granted without
42- * fee, provided that the above copyright notice appear in all copies
43- * and that both that copyright notice and this permission notice
44- * appear in supporting documentation, and that the name of
45- * Dennis Kasprzyk not be used in advertising or publicity pertaining to
46- * distribution of the software without specific, written prior permission.
47- * Dennis Kasprzyk makes no representations about the suitability of this
48- * software for any purpose. It is provided "as is" without express or
49- * implied warranty.
50- *
51- * DENNIS KASPRZYK DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
52- * INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN
53- * NO EVENT SHALL DENNIS KASPRZYK BE LIABLE FOR ANY SPECIAL, INDIRECT OR
54- * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
55- * OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
56- * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION
57- * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
58- *
59- * Authors: Dennis Kasprzyk <onestone@compiz-fusion.org>
60- */
61-
62-#ifndef _COMPPOINT_H
63-#define _COMPPOINT_H
64-
65-#include <vector>
66-#include <list>
67-
68-/**
69- * A 2D coordinate (likely in screen space) that can only be mutated
70- * through set() methods, since it's data members are private.
71- */
72-class CompPoint {
73-
74- public:
75- CompPoint ();
76- CompPoint (int, int);
77-
78- /**
79- * Get the x coordinate of this point
80- */
81- int x () const;
82-
83- /**
84- * Get the y coordinate of this point
85- */
86- int y () const;
87-
88- /**
89- * Set the x and y coordinate of this point
90- */
91- void set (int, int);
92-
93- /**
94- * Set the x coordinate of this point
95- */
96- void setX (int);
97-
98- /**
99- * Set the y coordinate of this point
100- */
101- void setY (int);
102-
103- bool operator== (const CompPoint &) const;
104- bool operator!= (const CompPoint &) const;
105-
106- /**
107- * Takes from both co-ordinates
108- */
109- CompPoint & operator-= (const CompPoint &);
110- /**
111- * Adds to both co-ordinates
112- */
113- CompPoint & operator+= (const CompPoint &);
114-
115- /**
116- * Retuns an added point
117- */
118- CompPoint operator+ (const CompPoint &) const;
119- /**
120- * Returns a subtracted point
121- */
122- CompPoint operator- (const CompPoint &) const;
123-
124- typedef std::vector<CompPoint> vector;
125- typedef std::vector<CompPoint *> ptrVector;
126- typedef std::list<CompPoint> list;
127- typedef std::list<CompPoint *> ptrList;
128-
129- private:
130- int mX, mY;
131-};
132-
133-inline int
134-CompPoint::x () const
135-{
136- return mX;
137-}
138-
139-inline int
140-CompPoint::y () const
141-{
142- return mY;
143-}
144-
145-
146-#endif

Subscribers

People subscribed via source and target branches