Merge lp:~vanvugt/compiz/fix-1048272 into lp:compiz/0.9.9

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3423
Merged at revision: 3430
Proposed branch: lp:~vanvugt/compiz/fix-1048272
Merge into: lp:compiz/0.9.9
Diff against target: 34 lines (+4/-0)
1 file modified
plugins/cube/src/cube.cpp (+4/-0)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1048272
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
PS Jenkins bot (community) continuous-integration Approve
MC Return Approve
Review via email: mp+129832@code.launchpad.net

Commit message

Restore cube transparency support for the top and bottom faces. It got
deleted as part of the GLES merge (r3320) in 0.9.8.0.
(LP: #1048272)

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :

Great job ! The cube is coming back to life :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/cube/src/cube.cpp'
2--- plugins/cube/src/cube.cpp 2012-10-12 09:05:18 +0000
3+++ plugins/cube/src/cube.cpp 2012-10-16 09:33:24 +0000
4@@ -1136,6 +1136,7 @@
5 #ifndef USE_GLES
6 priv->gScreen->setTexEnvMode (GL_MODULATE);
7 #endif
8+ glEnable (GL_BLEND);
9 glBlendFunc (GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
10 }
11
12@@ -1159,6 +1160,7 @@
13 priv->mTexture[0]->disable ();
14
15 priv->gScreen->setTexEnvMode (GL_REPLACE);
16+ glDisable (GL_BLEND);
17 glBlendFunc (GL_ONE, GL_ONE_MINUS_SRC_ALPHA);
18 }
19
20@@ -1202,6 +1204,7 @@
21 #ifndef USE_GLES
22 priv->gScreen->setTexEnvMode (GL_MODULATE);
23 #endif
24+ glEnable (GL_BLEND);
25 glBlendFunc (GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
26 }
27
28@@ -1216,6 +1219,7 @@
29 streamingBuffer->render (sTransform);
30
31 priv->gScreen->setTexEnvMode (GL_REPLACE);
32+ glDisable (GL_BLEND);
33 glBlendFunc (GL_ONE, GL_ONE_MINUS_SRC_ALPHA);
34 }
35

Subscribers

People subscribed via source and target branches