lp:~vanvugt/compiz/fix-1046661

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.8 at revision 3346

Sam Spilsbury: Approve on 2012-09-06

jenkins (community): Approve (continuous-integration) on 2012-09-06

Diff: 171 lines (+77/-36)

5 files modified

plugins/opengl/src/fsregion/fsregion.cpp (+2/-2)
plugins/opengl/src/fsregion/fsregion.h (+6/-4)
plugins/opengl/src/fsregion/tests/test-fsregion.cpp (+19/-0)
plugins/opengl/src/paint.cpp (+34/-30)
tests/manual/Unredirect.txt (+16/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1046661: "Unredirect Fullscreen Windows" stay on top (unredirected) even when an RGBA window is stacked above it

Medium

Fix Released

Link a bug report

Related blueprints

3349. By Daniel van Vugt on 2012-09-06

Clarify comment per smspillaz suggestion.

3348. By Daniel van Vugt on 2012-09-06

Minor comment update/correction.

3347. By Daniel van Vugt on 2012-09-06

Automated unit tests.

3346. By Daniel van Vugt on 2012-09-06

Fixed: Windows with an alpha-channel, like gnome-terminal, were not being
considered as possibly covering fullscreen windows. But they most certainly
can. This ensures such RGBA windows are visible if they're stacked above a
fullscreen window. (LP: #1046661)

3345. By Sam Spilsbury on 2012-09-05

Move statements to do with unminimize closer to their minimize counterparts,
express a function better by using constants rather than a compound statement.. Fixes: . Approved by jenkins, Daniel van Vugt.

3344. By Sam Spilsbury on 2012-09-05

Update the defaults to org.compiz.integrated to reflect the actual gnome values pre-gnome-3. Fixes: https://bugs.launchpad.net/bugs/1040081, https://bugs.launchpad.net/bugs/1046199. Approved by jenkins, Timo Jyrinki.

3343. By MC Return on 2012-09-05

Used 'if (normalData.empty ())' instead of 'if (normalData.size () == 0)', because checking for emptiness can be faster (2x).
Replaced post-increment with pre-increment operators, because those can be more efficient for non-primitive types.. Fixes: . Approved by Sam Spilsbury.

3342. By Timo Jyrinki on 2012-09-05

Partial fix to LP: #1046199 / LP: #1046190 fixing launch terminal functionality and making show-hud default key visible.. Fixes: https://bugs.launchpad.net/bugs/1040081, https://bugs.launchpad.net/bugs/1046190, https://bugs.launchpad.net/bugs/1046199. Approved by jenkins, Sam Spilsbury.

3341. By MC Return on 2012-09-05

Reduced the scope of various variables (y1, x2, y2, deformedX, deformedY, deformedZ, gridW, gridH) in plugins/animation/src/grid.cpp and of the variable 'buf' in water.cpp.. Fixes: . Approved by Sam Spilsbury.

3340. By Daniel van Vugt on 2012-09-05

Ensure unredirected windows don't stay unredirected if they're no longer
on top. (LP: #1041047). Fixes: https://bugs.launchpad.net/bugs/1041047. Approved by Sam Spilsbury, jenkins.