Merge lp:~vanvugt/compiz/fix-1020830 into lp:compiz/0.9.9
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt on 2013-01-08 |
Approved revision: | 3542 |
Merged at revision: | 3548 |
Proposed branch: | lp:~vanvugt/compiz/fix-1020830 |
Merge into: | lp:compiz/0.9.9 |
Diff against target: |
185 lines (+25/-23) 7 files modified
debian/compiz-plugins.install (+1/-0) debian/compiz-plugins.install.armel (+1/-0) debian/compiz-plugins.install.armhf (+1/-0) plugins/CMakeLists.txt (+0/-1) plugins/wallpaper/CMakeLists.txt (+1/-1) plugins/wallpaper/src/wallpaper.cpp (+19/-19) plugins/wallpaper/src/wallpaper.h (+2/-2) |
To merge this branch: | bzr merge lp:~vanvugt/compiz/fix-1020830 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve on 2013-01-08 | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing on 2013-01-08 | |
Sam Spilsbury | 2013-01-07 | Approve on 2013-01-07 | |
Review via email:
|
Commit message
Reintroduced the wallpaper plugin. It was unbuildable from v0.9.8.0 until
now. (LP: #1020830)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:3541
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://
Daniel van Vugt (vanvugt) wrote : | # |
Yeah alpha() appeared to be false (which is correct) so the plugin could not work at all with that check.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
- 3542. By Daniel van Vugt on 2013-01-08
-
Remember to install wallpaper for ARM too
Yay. Happy to have this in as is (as its non-core), only question would be, do you know why:
- window->alpha () && window->type () & CompWindowTypeD esktopMask) esktopMask)
+ window->type () & CompWindowTypeD
The check for alpha () was removed? I believe that was necessary for some reason, something to do with the transparent cube. Or something.
I guess if it was breaking more things than it fixed, then its not worth having.