Merge lp:~vanvugt/compiz/fix-1009338 into lp:compiz/0.9.8

[Daniel van Vugt]

Fall back to a refresh rate that is more likely to look correct; 60Hz.
(LP: #1009338)

The fallback is still only used if sync-to-vblank is not available (disabled
in the driver) AND if xrandr doesn't provide a refresh rate.

[Sam Spilsbury (smspillaz)]

Approve, please change

+#define FALLBACK_REFRESH_RATE 60 /* if all else fails */

To

static const unsigned int FALLBACK_REFRESH_RATE = 60

review: Approve

[lp:~vanvugt/compiz/fix-1009338]

3246. By Daniel van Vugt on 2012-06-06

Stylistic request to avoid macros.

Though doing so does have the added benefit of generating a symbol you can
see in a debugger.

[Sam Spilsbury (smspillaz)]

review: Approve

=== modified file 'plugins/composite/composite.xml.in'
--- plugins/composite/composite.xml.in	2012-06-05 07:40:03 +0000
+++ plugins/composite/composite.xml.in	2012-06-06 07:36:39 +0000
@@ -16,7 +16,7 @@
 	    <option name="refresh_rate" type="int">
 		<_short>Refresh Rate</_short>
 		<_long>The rate at which the screen is redrawn (times/second)</_long>
-		<default>50</default>
+		<default>60</default>
 		<min>1</min>
 		<max>200</max>
 	    </option>

=== modified file 'plugins/composite/src/screen.cpp'
--- plugins/composite/src/screen.cpp	2012-06-06 05:12:28 +0000
+++ plugins/composite/src/screen.cpp	2012-06-06 07:36:39 +0000
@@ -45,6 +45,8 @@
 
 #include <core/timer.h>
 
+static const int FALLBACK_REFRESH_RATE = 60;   /* if all else fails */
+
 CompWindow *lastDamagedWindow = 0;
 
 void
@@ -274,8 +276,8 @@
     exposeRects (),
     windowPaintOffset (0, 0),
     overlayWindowCount (0),
-    redrawTime (1000 / 50),
-    optimalRedrawTime (1000 / 50),
+    redrawTime (1000 / FALLBACK_REFRESH_RATE),
+    optimalRedrawTime (1000 / FALLBACK_REFRESH_RATE),
     scheduled (false),
     painting (false),
     reschedule (false),
@@ -651,7 +653,7 @@
 	}
 
 	if (value.i () == 0)
-	    value.set ((int) 50);
+	    value.set ((int) FALLBACK_REFRESH_RATE);
 
 	mOptions[CompositeOptions::DetectRefreshRate].value ().set (false);
 	screen->setOptionForPlugin ("composite", "refresh_rate", value);