Merge lp:~vanvugt/compiz-resizeinfo-plugin/fix-887434 into lp:compiz-resizeinfo-plugin

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 71
Proposed branch: lp:~vanvugt/compiz-resizeinfo-plugin/fix-887434
Merge into: lp:compiz-resizeinfo-plugin
Diff against target: 13 lines (+2/-1)
1 file modified
src/resizeinfo.cpp (+2/-1)
To merge this branch: bzr merge lp:~vanvugt/compiz-resizeinfo-plugin/fix-887434
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+81526@code.launchpad.net

Description of the change

Fixed resize info not being displayed for semi-maximized windows (LP: #887434)

The bug was caused by assuming MAXIMIZE_STATE is a single bit. Actually it is 2 bits and resize info should only refuse to display if both bits are set.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

+1 thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/resizeinfo.cpp'
2--- src/resizeinfo.cpp 2010-05-24 16:10:41 +0000
3+++ src/resizeinfo.cpp 2011-11-08 07:00:31 +0000
4@@ -302,7 +302,8 @@
5 {
6 INFO_SCREEN (screen);
7
8- if ((!is->pWindow || !is->drawing) && !(window->state () & MAXIMIZE_STATE))
9+ if ((!is->pWindow || !is->drawing) &&
10+ ((window->state () & MAXIMIZE_STATE) != MAXIMIZE_STATE))
11 {
12 bool showInfo;
13 showInfo = (((window->sizeHints ().width_inc != 1) &&

Subscribers

People subscribed via source and target branches