Compiz Resize Info Plugin

Merge lp:~vanvugt/compiz-resizeinfo-plugin/fix-877920 into lp:compiz-resizeinfo-plugin

  1. fix-877920
  2. Merge into 0.9.5
Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 71
Proposed branch: lp:~vanvugt/compiz-resizeinfo-plugin/fix-877920
Merge into: lp:compiz-resizeinfo-plugin
Diff against target: 10 lines (+1/-0)
1 file modified
src/resizeinfo.cpp (+1/-0)
To merge this branch: bzr merge lp:~vanvugt/compiz-resizeinfo-plugin/fix-877920
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+81435@code.launchpad.net

Description of the change

Fixed (all) windows becoming unexpectedly translucent when Resize Info activates (LP: #877920)

Fixed GL_TEXTURE_ENV_MODE being left in an unclean state (GL_MODULATE) when it should be GL_REPLACE. This was causing the state to leak into other parts of compiz like window decoration so windows would accidentally become translucent.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

A general fix to protect compiz from this kind of mistake in any plugin has also been proposed:
https://code.launchpad.net/~vanvugt/compiz-core/fix-877920/+merge/81436

We should commit both fixes; cover all the bases and minimize the chances of bugs like this happening anywhere in future.

Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/resizeinfo.cpp'
2--- src/resizeinfo.cpp 2010-05-24 16:10:41 +0000
3+++ src/resizeinfo.cpp 2011-11-07 08:53:23 +0000
4@@ -433,6 +433,7 @@
5 backgroundLayer.draw (x, y);
6 textLayer.draw (x, y);
7
8+ gScreen->setTexEnvMode (GL_REPLACE);
9 glDisable (GL_BLEND);
10 glEnableClientState (GL_TEXTURE_COORD_ARRAY);
11

Subscribers

People subscribed via source and target branches