lp:~vanvugt/compiz-core/tapping-panacea
- Get this branch:
- bzr branch lp:~vanvugt/compiz-core/tapping-panacea
Branch merges
- Alan Griffiths: Approve
-
Diff: 99 lines (+16/-20)4 files modifiedmetadata/core.xml.in (+0/-7)
src/event.cpp (+1/-8)
src/privatescreen.h (+0/-3)
src/screen.cpp (+15/-2)
Related bugs
Related blueprints
Branch information
Recent revisions
- 3050. By Daniel van Vugt
-
Reliable tap detection without compromise (!)
Eliminated the timing hack. Instead use individual passive grabs on
<modifier>+each_key to detect whether <modifier> is being tapped, or used
to modifier another key. - 3048. By Daniel van Vugt
-
Improved the fix for LP: #943194 so that it now works with GTK-2 menus too.
The first attempt only worked with GTK-3 it seems.This also required that the fix for LP: #806255 be redesigned to avoid
XGrabKeyboard completely. Because that was part of what broke GTK-2 menus. - 3046. By Daniel van Vugt
-
Don't keep an active keyboard grab the whole time a shortcut key is held
down. Doing so was causing multiple bugs with Unity 5, which binds to
the Alt key. Instead use some simple heurisitics to decide if a key has
been "tapped" or not. (LP: #943194) (LP: #943851) (LP: #945373)Yes, it is a compromise to go back to detecting taps based on timing.
However it is the only existing solution to all of these bugs related to
the Alt key. - 3045. By Daniel van Vugt
-
Don't respond to hotkeys if some other window (like a VM or locked
screen saver) already has an active keyboard grab. (LP: #806255)Also fixed a minor pointer mistake in isBound(), and removed a redundant
call to XFlush. - 3044. By Daniel van Vugt
-
Avoid crashing if the decoration window is NULL. Not sure how to
reproduce the crash, but this should avoid it (LP: #937815) - 3043. By Daniel van Vugt
-
Avoid pointlessly doing a full copy of a linked list every frame when the
copy is never changed and never different to the source. This cuts an
instant 6-9% from compiz' CPU usage (LP: #946887) - 3042. By Daniel van Vugt
-
Don't load plugins if you failed to initialize the screen. That will
cause an assertion failure and probably other issues too. (LP: #946118) - 3041. By Alan Griffiths
-
Started as cleaning up some pointless temporaries on the heap and ended by
getting rid of a pointless and dangerous CoreWindow class.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:compiz-core