lp:~vanvugt/compiz-core/revert-lim

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core at revision 3077

Sam Spilsbury: Approve on 2012-03-30

Didier Roche-Tolomelli: Approve on 2012-03-30

Diff: 1601 lines (+11/-1218)

16 files modified

gtk/window-decorator/CMakeLists.txt (+0/-6)
gtk/window-decorator/decorator.c (+6/-32)
gtk/window-decorator/events.c (+3/-117)
gtk/window-decorator/gtk-window-decorator.c (+0/-59)
gtk/window-decorator/gtk-window-decorator.h (+1/-8)
gtk/window-decorator/local-menus/CMakeLists.txt (+0/-60)
gtk/window-decorator/local-menus/src/local-menus.c (+0/-438)
gtk/window-decorator/local-menus/src/local-menus.h (+0/-125)
gtk/window-decorator/local-menus/tests/CMakeLists.txt (+0/-3)
gtk/window-decorator/local-menus/tests/check_local_menu_on_off/CMakeLists.txt (+0/-21)
gtk/window-decorator/local-menus/tests/check_local_menu_on_off/test-local-menu-on-off.cpp (+0/-47)
gtk/window-decorator/local-menus/tests/force_local_menu_on/CMakeLists.txt (+0/-21)
gtk/window-decorator/local-menus/tests/force_local_menu_on/test-force-local-menu-on.cpp (+0/-89)
gtk/window-decorator/local-menus/tests/test-local-menu.h (+0/-106)
gtk/window-decorator/metacity.c (+0/-54)
gtk/window-decorator/wnck.c (+1/-32)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #962085: [0.9.7.2] gtk-window-decorator receives BadWindow errors

High

Fix Released

Link a bug report

Related blueprints

3077. By Daniel van Vugt on 2012-03-30

Revert locally integrated menus support because it is not being used and
is apparently causing a regression (LP: #962085)

This reverts LP: #931245 and LP: #682788.

3076. By Sam Spilsbury on 2012-03-30

Use the stack order when determining the next window to focus instead
of the focus order when click focus is enabled. (LP: #888704)

3075. By Alan Griffiths on 2012-03-30

Avoid graphics corruption and hangs on compiz start-up by ensuring that
plugins don't get initialized, de-initialized and re-initialzed during
start-up. (LP: #963093) (LP: #963633)

The multiple init/fini/init calls occured when compiz was asked to load an
invalid plugin name. This occurred most recently as plugins "bailer" and
"detection" were left in some peoples' configs while the plugins themselves
no longer exist in the current compiz release.

The source of the graphics corruption and hangs has been found to be a
problem in the composite and/or opengl plugins. One or both of them are unsafe
to init/fini multiple times without a full compiz restart. So the root cause
is not exactly known yet. However composite and opengl are not alone; many
plugins have bugs with init/fini/init sequences, so it is valuable to fix
the start-up plugin ordering as this does.

Essentially this fix works by remembering which plugins don't exist at all
and putting them on a black list. Then subsequent updates check the blacklist
and know they should never include those failed plugins in testing whether
the active plugin lists have changed.

The final part of the fix is to remove a rendundant call to updatePlugins from
EventManager::init. It is not required as main tells PluginManager when to
load plugins on startup.

IMPORTANT NOTE FOR UBUNTU PACKAGING
In downstream ubuntu branches the DEFAULT_PLUGINS list in "debian/rules" also
causes multiple plugin loads on start-up and prevents this fix from working!
The solution is to change DEFAULT_PLUGINS to just "ccp".

3074. By Alan Griffiths on 2012-03-29

Some additional testing of updatePlugins inspired by #963264

3073. By Alan Griffiths on 2012-03-29

Revert change that core dumps test

3072. By Alan Griffiths on 2012-03-29

Some additional testing of updatePlugins inspired by #963264

3071. By Sam Spilsbury on 2012-03-27

Fix LP#964248 - Build GTest locally

3070. By Daniel van Vugt on 2012-03-27

Fixed: Composite would fail to initialize even when it was the only
composite window manage running. This was because it leaked its handles
and in the unusual cases where plugin load failures cause other plugins to
unload/reload, composite would fail to init the second time.
(LP: #963465) (LP: #963465) (LP: #833729)

3069. By Daniel van Vugt on 2012-03-25

Fixed Super key release events sometimes not being sent to plugins
(LP: #963470)

This regression was caused by the latest fix for LP: #806255, which has now
been removed. That was the third different fix attempted for #806255 and all
three have caused different regressions. So #806255 will not be fixed for
now. The only remaining fix (guaranteed to work) for that bug is to eliminate
and rewrite the XkbStateNotify code in compiz-core and several plugins.
However that is a massive change we can't afford to risk right now. So we
need to accept that LP: #806255 won't be fixed for a while.

3068. By Daniel van Vugt on 2012-03-23

[Coverity] Avoid potential NULL pointer dereference (LP: #957572)