Code review comment for lp:~vanvugt/compiz-core/fix-startup-plugins

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Looks good to me.

I would also say there's another case this branch doesn't handle, which is the case where a plugin fails to load because it either a) can't be loaded or b) can't be loaded because of a missing plugin dep. In that case, I think we should put such plugins at the back of the list at the end of every new push. Dependencies will in that case be automatically resolved if the user tries to load the dependend plugin A as A will load and dependent plugin B will load thereafter. It also avoids the mass push/pop if a plugin was failing to init and in the middle of the list.

review: Approve

« Back to merge proposal