Merge lp:~vanvugt/compiz-core/fix-960831 into lp:compiz-core

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 3065
Proposed branch: lp:~vanvugt/compiz-core/fix-960831
Merge into: lp:compiz-core
Diff against target: 25 lines (+7/-4)
1 file modified
src/event.cpp (+7/-4)
To merge this branch: bzr merge lp:~vanvugt/compiz-core/fix-960831
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+98571@code.launchpad.net

Description of the change

Don't allow plugins (unity) to interfere with tap detection by blocking
compiz-core from handling key events (LP: #960831)

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Looks very sensible to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/event.cpp'
2--- src/event.cpp 2012-03-19 10:21:02 +0000
3+++ src/event.cpp 2012-03-21 04:00:25 +0000
4@@ -1060,14 +1060,17 @@
5 void
6 CompScreenImpl::alwaysHandleEvent (XEvent *event)
7 {
8+ /*
9+ * Critical event handling that cannot be overridden by plugins
10+ */
11+
12+ if (event->type == ButtonPress || event->type == KeyPress)
13+ priv->possibleTap = NULL;
14+
15 eventHandled = true; // if we return inside WRAPABLE_HND_FUNCTN
16
17 handleEvent (event);
18
19- /*
20- * Critical event handling that cannot be overridden by plugins
21- */
22-
23 bool keyEvent = (event->type == KeyPress || event->type == KeyRelease);
24
25 /* Always either replay the keyboard or consume the key

Subscribers

People subscribed via source and target branches