Merge lp:~vanvugt/compiz-core/fix-953089 into lp:compiz-core

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 3059
Proposed branch: lp:~vanvugt/compiz-core/fix-953089
Merge into: lp:compiz-core
Diff against target: 30 lines (+2/-8)
2 files modified
NEWS (+2/-0)
src/event.cpp (+0/-8)
To merge this branch: bzr merge lp:~vanvugt/compiz-core/fix-953089
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Review via email: mp+98149@code.launchpad.net

Description of the change

Remove logic to cancel a tap on focus change. It's no longer required since
r3050, and looks like it might be contributing to incorrect tap detection
in some cases with empty workspaces (LP: #953089)

To post a comment you must log in.
lp:~vanvugt/compiz-core/fix-953089 updated
3060. By Daniel van Vugt

Update NEWS too

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Don't see any problems

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2012-03-16 07:59:22 +0000
3+++ NEWS 2012-03-19 08:12:21 +0000
4@@ -22,6 +22,8 @@
5 `priv->initialized' failed.
6 946887 - Compiz spends >8% of its time in
7 std::list<CompWindow*>::operator=(std::list<CompWindow*>)
8+ 953089 - Unity 5.6: key bindings (such as Super) don't work on empty
9+ workspace or on slow/loaded systems
10
11
12 Release 0.9.7.0 ( 2012-03-02 smspillaz <sam.spilsbury@canonical.com> )
13
14=== modified file 'src/event.cpp'
15--- src/event.cpp 2012-03-12 10:35:21 +0000
16+++ src/event.cpp 2012-03-19 08:12:21 +0000
17@@ -1906,14 +1906,6 @@
18 break;
19 case FocusIn:
20 {
21- /* When a menu etc gets a grab, it's safe to say we're not tapping
22- any key right now. e.g. Detecting taps of "Alt" and cancelling
23- when a menu is opened */
24- if (event->xfocus.mode == NotifyGrab &&
25- event->xfocus.window != priv->root &&
26- priv->notGrabWindow (event->xfocus.window))
27- priv->possibleTap = NULL;
28-
29 if (!XGetWindowAttributes (priv->dpy, event->xfocus.window, &wa))
30 priv->setDefaultWindowAttributes (&wa);
31

Subscribers

People subscribed via source and target branches