Merge lp:~vanvugt/compiz-core/fix-943223 into lp:compiz-core

[Daniel van Vugt]

Ungrab keyboard as soon as a key is pressed. Don't wait for it to be
released. This (probably) solves a regression apparently introduced in
r3006. (LP: #943223)

I can't be totally sure this fixes bug 943223 because:
  (a) My Unity 5 test machine does not exhibit the problem at all and I can't update it to retry till tomorrow; and
  (b) The test case makes no sense. Alt+F10 is meant to maximize windows. And that's what it does on all my machines.

I'm fairly confident that this change is otherwise benign. And can't exactly remember why r3006 changed KeyPress to KeyRelease in the first place.

[Didier Roche-Tolomelli (didrocks)]

Just a note on the test: it makes tests because:
- alt + F10 is used in unity to reveal the menu
- compiz is distro-patch so that maximize a window is not alt + F10 is Super + Up arrow, as per design request.
Hence the importance that distro-patch goes to upstream compiz, or that people working on ubuntu for unity ensured to have the downstream configuration and distro-patches.

[Alan Griffiths (alan-griffiths)]

The change appears to do what it says. Not sure how best to validate it does what's intended though.

[Daniel van Vugt (vanvugt)]

If nothing else, you can verify that this line of code is identical or equivalent to all revisions of lp:compiz-core up to and including r3005.

[Sam Spilsbury (smspillaz)]

review: Approve

[Alan Griffiths (alan-griffiths)]

> If nothing else, you can verify that this line of code is identical or
> equivalent to all revisions of lp:compiz-core up to and including r3005.

That much is true.

review: Approve

=== modified file 'src/event.cpp'
--- src/event.cpp	2012-02-22 05:13:00 +0000
+++ src/event.cpp	2012-03-01 11:45:21 +0000
@@ -1057,7 +1057,7 @@
 	XAllowEvents (priv->dpy, mode, event->xkey.time);
     }
 
-    if (priv->grabs.empty () && event->type == KeyRelease)
+    if (priv->grabs.empty () && event->type == KeyPress)
     {
 	XUngrabKeyboard (priv->dpy, event->xkey.time);
 	priv->tapGrab = false;