Code review comment for lp:~vanvugt/compiz-core/fix-940139
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
I will add tests for CompRegionRef. Forgot about that class (which was added) after I added and then removed other CompRegion test cases (for methods that I added, then decided to remove).
Re: Indentation, I always use the tab/space combinations that fit the context, using the same style as the existing nearby code does. I did get the impression that pure spaces was preferred to new code, but if you prefer the tab/space combination for new code then I can go back to that.