lp:~vanvugt/compiz-core/fix-940139

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core at revision 3023

Alan Griffiths: Approve on 2012-02-27

Diff: 420 lines (+105/-96)

6 files modified

include/core/region.h (+12/-4)
plugins/decor/src/decor.cpp (+20/-12)
plugins/decor/src/decor.h (+1/-0)
plugins/opengl/src/paint.cpp (+2/-2)
src/privateregion.h (+0/-41)
src/region.cpp (+70/-37)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #940139: [callgrind] compiz spends about 51% of its CPU time in CompRegion construction/destruction

High

Fix Released

Link a bug report

Related blueprints

3024. By Daniel van Vugt on 2012-02-27

Remove #if's that will probably never be used. Also remove subsequently
dead code.

3023. By Daniel van Vugt on 2012-02-27

A little more const.

3022. By Daniel van Vugt on 2012-02-27

Major optimizations in decor and opengl to minimize how often CompRegions
are constructed/destroyed. Now CompRegion ctors/dtor only represents about
4.4% of compiz CPU usage.

3021. By Daniel van Vugt on 2012-02-27

Simplified and optimized further. Now CompRegion ctors/dtor only account
for 8% of compiz CPU usage.

3020. By Daniel van Vugt on 2012-02-26

Reduced the amount of time spent constructing and destructing CompRegions
from 51% to 9%. This reduces compiz' overall CPU usage by 42%! (LP: #940139)

This makes compiz so fast that even running under callgrind I now get
smooth GL and video performance.

3019. By Daniel van Vugt on 2012-02-24

Initial prototype (untested)

3018. By Alan Griffiths on 2012-02-23

Avoid SIGSEGV in XDefineCursor() when display fails to initialize. (Bug #936487)

3017. By Sam Spilsbury on 2012-02-23

Check if the mutter key exists before using it. This fixes the lack of
draggable borders if mutter isn't installed. (LP: #936781)

3016. By Daniel van Vugt on 2012-02-22

Fix keyboard lockup, which occurred when a plugin was devious enough to
override handleEvent and not allow keyboard events to reach core.
(LP: #934058)

Arguably we should fix the offending plugin (unityshell). But I figured it's
better to make core more robust so that the same bug can never occur with
any plugin in future.

3015. By Daniel van Vugt on 2012-02-22

Remove dead code (extern declarations of non-existent globals).