lp:~vanvugt/compiz-core/fix-938417

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core at revision 3055

Alan Griffiths: Approve on 2012-03-13

Diff: 108 lines (+19/-9)

4 files modified

cmake/CompizBcop.cmake (+5/-2)
metadata/CMakeLists.txt (+8/-6)
src/CMakeLists.txt (+4/-1)
src/plugin/CMakeLists.txt (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #938417: lp:compiz-core fails parallel builds (make -jN)

Medium

Fix Released

Link a bug report

Related blueprints

3055. By Daniel van Vugt on 2012-03-13

Corrected CMake target dependencies so that parallel builds now work,
as in "make -j8" (LP: #938417)

3054. By Alan Griffiths on 2012-03-13

Decouple EventManager from rest of what was PrivateScreen

3053. By Alan Griffiths on 2012-03-12

Decouple History from rest of what was PrivateScreen

3052. By Alan Griffiths on 2012-03-12

Decouple GrabManager from rest of what was PrivateScreen

3051. By Alan Griffiths on 2012-03-12

CompIcon had some design errors:

/1/ it contained two copies of CompSize (a member and a base);
/2/ it allowed non-const use of base CompSize member functions (which breaks
    invariants);
/3/ it could be copied/assigned leading to double-delete of mData; and,
/4/ it could be "sliced" leading to leak of mData.

None of the core code did any of 2-4, but they'll no longer compile.

3050. By Daniel van Vugt on 2012-03-09

Reliable tap detection without compromise (!)

Eliminated the timing hack. Instead use individual passive grabs on
<modifier>+each_key to detect whether <modifier> is being tapped, or used
to modify another key.

3049. By Alan Griffiths on 2012-03-09

Encapsulate grabs - the list of Grab*

3048. By Daniel van Vugt on 2012-03-08

Improved the fix for LP: #943194 so that it now works with GTK-2 menus too.
The first attempt only worked with GTK-3 it seems.

This also required that the fix for LP: #806255 be redesigned to avoid
XGrabKeyboard completely. Because that was part of what broke GTK-2 menus.

3047. By Alan Griffiths on 2012-03-08

Decouple PluginManager from rest of what was PrivateScreen

3046. By Daniel van Vugt on 2012-03-07

Don't keep an active keyboard grab the whole time a shortcut key is held
down. Doing so was causing multiple bugs with Unity 5, which binds to
the Alt key. Instead use some simple heurisitics to decide if a key has
been "tapped" or not. (LP: #943194) (LP: #943851) (LP: #945373)

Yes, it is a compromise to go back to detecting taps based on timing.
However it is the only existing solution to all of these bugs related to
the Alt key.