lp:~vanvugt/compiz-core/fix-934058

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core at revision 3016

Sam Spilsbury: Approve on 2012-02-22

Diff: 144 lines (+39/-22)

5 files modified

include/core/screen.h (+2/-1)
src/event.cpp (+32/-20)
src/privatescreen.h (+2/-0)
src/privatescreen/tests/test-privatescreen.cpp (+1/-0)
src/screen.cpp (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #934058: [regression] Launcher, top panel and keyboard un-responsive after using any Super-x shortcut

Critical

Fix Released

Link a bug report

Related blueprints

3015. By Daniel van Vugt on 2012-02-22

Minor tidy-up, to ensure no important CompScreenImpl logic is inside
CompScreen::handleEvent because it will be called repeatedly in the
wrapped function call stack.

3014. By Daniel van Vugt on 2012-02-21

Fix keyboard lockup, which occurred when a plugin was devious enough to
override handleEvent and not allow keyboard events to reach core.
(LP: #934058)

Arguably we should fix the offending plugin (unityshell). But I figured it's
better to make core more robust so that the same bug can never occur with
any plugin in future.

3013. By Sam Spilsbury on 2012-02-20

Fix typo which would cause maximized windows to not receive shadows at all

3012. By Sam Spilsbury on 2012-02-20

Also update state, actions and icon whenever the window becomes redecorated
as those may have changed while the window was undecorated

Merge lp:~smspillaz/compiz-core/compiz-core.fix_936778 into lp:compiz-core

3011. By Sam Spilsbury on 2012-02-20

  Don't silently let windows that we couldn't find a sibling below for sit
  at the top of the stack (LP #936675)

  If we couldn't find a sibling for the window upon initial map, then it means
  that it needs to be placed at the bottom of the stack, since there could be
  windows above it which should not be below the newly created window.

  Fixes a case where on startup, nautilus could be slow to load and new windows
  would be created before nautilus was, and those would go above panels incorrectly.

Merge lp:~smspillaz/compiz-core/compiz-core.fix_936675 into lp:compiz-core

3010. By Sam Spilsbury on 2012-02-20

Only call removeAction on the CompOption destructor and not the CompOption::Value
destructor, since plugins that make copies of CompOption::Value can cause actions to
be added through setOptionForPlugin and then those actions will be removed when the
value temporary goes away.

The action adding and removing only happens within the bounds of CompOption anyways, so
its its more appropriate to have it in its destructor.

Of course, this brings up another issue, which is that CompOption should be noncopyable
but this opens up a whole another can of worms.

How this even worked before is beyond me...

Merge lp:~smspillaz/compiz-core/compiz-core.fix_931927 into lp:compiz-core

3009. By Sam Spilsbury on 2012-02-20

Fixes the state atoms never being unset if no bits were being set.
This fixes the previous commit, which was a fix for LP: #932087.

3008. By Sam Spilsbury on 2012-02-19

Refactor out fillStateData since it was being duplicated in a plugin that
was causing bug 932087. (LP: #932087)

3007. By Gabor Kelemen on 2012-02-19

Fix untranslated strings - Add missing files to POTFILES.in. (LP: #780505)

3006. By Daniel van Vugt on 2012-02-17

Improved the fix for LP: #925293 (add tap support):
  * Add correct tap detection for non-modifier-only key combinations.
  * Avoid getting "stuck" with modifiers apparently locked down.
  * Ungrab the keyboard on key releases, not presses.
  * ReplayKeyboard of release events as well as presses (previously only
    presses, which could cause release events to queue up and block the
    server).