lp:~vanvugt/compiz-core/fix-925293

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core at revision 3002

Tim Penhey (community): Approve on 2012-02-15

Gord Allott: Pending requested 2012-02-15

Diff: 395 lines (+133/-58)

6 files modified

include/core/action.h (+2/-1)
plugins/water/src/water.cpp (+9/-1)
plugins/water/water.xml.in (+3/-0)
src/event.cpp (+105/-55)
src/privatescreen.h (+11/-1)
src/screen.cpp (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #925293: Plugins can't tell the difference between a modifier key-tap, and a modifier key-release (after being used to modify other keys)

High

Fix Released

Link a bug report

Related blueprints

3003. By Daniel van Vugt on 2012-02-15

Preventative maintenance;
  1. Don't grab the keyboard if some other plugin already has.
  2. Make possibleTap a void* so that no one tries to dereference it.
  3. Reset possibleTap when plugins change, so there can be no confusion.

3002. By Daniel van Vugt on 2012-02-14

Smaller implementation of tap detection (LP: #925293)

This version is smaller because it uses the existing Terminate logic and
allows you to decide in your Terminate callback whether you want to respond
just to "taps" to to all key releases.

If your Terminate callback has both state bits set:
    CompAction::StateTermKey
    CompAction::StateTermTapped
then you can be sure the key was tapped and not used as a modifier of another
key.

3001. By Daniel van Vugt on 2012-02-13

Comment out the test case (water plugin)

3000. By Daniel van Vugt on 2012-02-13

Remove debugging code and tidy up.

2999. By Daniel van Vugt on 2012-02-13

First fully-functioning version.

2998. By Daniel van Vugt on 2012-02-13

Fixed the aforementioned issue.

New issue: Need to ungrab the keyboard at the right time yet. It remains
grabbed if a tap was triggered. Everything else seems to work now.

2997. By Daniel van Vugt on 2012-02-10

Some progress made.

Now a tap is only triggered by an actual key tap and not if it's being used
as a modifier. One remaining bug however: The first modifier+otherkey press
is absorbed and never reaches the app. So pressing ^C in a terminal does
nothing the first try, but works thereafter.

2996. By Daniel van Vugt on 2012-02-10

Initial "tap" support (trigger an action on press-and-release but only when
nothing else was pressed in between). (LP: #925293)

FIXME: Still missing detection of the intermediate application keystrokes
that compiz doesn't have passive grabs for.

2995. By Alan Griffiths on 2012-02-09

Another function resurrected

2994. By Alan Griffiths on 2012-02-09

Fix for https://bugs.launchpad.net/compiz-plugins-extra/+bug/929449 and failing tests in package build