Merge lp:~vanvugt/compiz-core/fix-923683 into lp:compiz-core/0.9.5

[Daniel van Vugt]

Fix erratic and buggy window movement by reverting to a pure and simple
async model. Avoids feedback loops and all sorts of server/client confusion.
(LP: #923683)

[Daniel van Vugt (vanvugt)]

This feels related to bug 898465 too.

[Alan Griffiths (alan-griffiths)]

Any performance issue?

review: Approve

[Sam Spilsbury (smspillaz)]

This will result in some unpredictable behaviour due to the raceyness of syncPosition and friends, but I'd rather merge it anyways.

=== modified file 'plugins/move/src/move.cpp'
--- plugins/move/src/move.cpp	2012-01-20 14:42:53 +0000
+++ plugins/move/src/move.cpp	2012-01-31 07:11:25 +0000
@@ -487,18 +487,8 @@
 	    w->move (wX + dx - w->geometry ().x (),
 		     wY + dy - w->geometry ().y (), false);
 
-	    if (ms->optionGetLazyPositioning () && ms->hasCompositing)
-	    {
-		/* FIXME: This form of lazy positioning is broken and should
-		   be replaced asap. Current code exists just to avoid a
-		   major performance regression in the 0.5.2 release. */
-		w->serverGeometry ().setX (w->geometry ().x ());
-		w->serverGeometry ().setY (w->geometry ().y ());
-	    }
-	    else
-	    {
+	    if (!ms->optionGetLazyPositioning ())
 		w->syncPosition ();
-	    }
 
 	    ms->x -= dx;
 	    ms->y -= dy;